Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix styling for version comparison #791

Merged
merged 2 commits into from
Aug 7, 2023
Merged

feat: Fix styling for version comparison #791

merged 2 commits into from
Aug 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 3, 2023 •
edited
Loading

Screenshot 2023-08-07 at 12 08 01

This was referenced Aug 3, 2023
Merged
Closed
@juliusknorr juliusknorr force-pushed the enh/version-compare branch from 7d8ef25 to a284e63 Compare August 4, 2023 07:45
@juliusknorr juliusknorr marked this pull request as ready for review August 7, 2023 10:08
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Aug 7, 2023
max-nextcloud
max-nextcloud approved these changes Aug 7, 2023
View reviewed changes
Copy link

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the code after our walk through. Changes make sense. Did not test locally though.

@juliusknorr
Copy link
Member Author

/compile

@nextcloud-command
chore(assets): Recompile assets
85eb9e2 
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 186e6d4 into master Aug 7, 2023
@juliusknorr juliusknorr deleted the enh/version-compare branch August 7, 2023 17:35
@juliusknorr
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @max-nextcloud @nextcloud-command