Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notice instead of error message #398

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Make notice instead of error message #398

merged 1 commit into from
Nov 19, 2024

Conversation

melroy89
Copy link
Contributor

  • Change error messages like "No matching rule for response [INSTREAM size limit exceeded. ERROR]." a notice, rather than an error message.
  • Fix error pollution

Fixes: #397

@melroy89
Make notice instead of error message
88a548f 
Signed-off-by: Melroy van den Berg <[email protected]>
@icewind1991 icewind1991 merged commit bc3adb7 into nextcloud:master Nov 19, 2024
50 of 53 checks passed
@icewind1991
Copy link
Member

Makes sense

@melroy89
Copy link
Contributor Author

melroy89 commented Nov 19, 2024 •
edited
Loading

Thank you!

Ps. if notice for whatever reason not work with nextcloud, we can always use info..

@melroy89 melroy89 deleted the patch-1 branch November 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INSTREAM size limit exceeded should become a warning or info level message
2 participants
@melroy89 @icewind1991