Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get proper errer message when the connection to an ICAP Server fails #365

Conversation

unglaublicherdude
Copy link

this is in response to this thread.

Previous Behaviour: When the client was not able to connect the stream was not set, resulting in an error when calling the socket_set_timeout function.

Changed Behaviour: When the is not able to connect the RuntimeException will be thrown with proper ErrorMessage and ErrorCode.

this is in response [to this thread](https://help.nextcloud.com/t/error-when-try-a-save-profile-settings-when-changing-settings-for-antivirus-when-using-an-icap-profile/199787/2).

Previous Behaviour: When the client was not able to connect the stream was not set, resulting in an error when calling the socket_set_timeout function.

Changed Behaviour: When the is not able to connect the RuntimeException will be thrown with proper ErrorMessage and ErrorCode.

Signed-off-by: Version Bot <[email protected]>
@unglaublicherdude unglaublicherdude changed the title moves the stream check Get proper errer message when the connection to an ICAP Server fails Aug 2, 2024
@unglaublicherdude
Copy link
Author

Is there something that still hast to be done by me?
The steps failing were not touched by me. Here is the workflowfile invalid. https://github.com/nextcloud/files_antivirus/actions/runs/10211785337/job/28266395368

@joshtrichards joshtrichards self-requested a review August 10, 2024 16:14
@joshtrichards
Copy link
Member

The lint test is failing due to formatting and at least one of the unit tests I sampled is failing due to a difference in the error output in the new test in this PR:

Failed asserting that exception message 'Cannot connect to "tcp://nothinghere:8080": php_network_getaddresses: getaddrinfo for nothinghere failed: Temporary failure in name resolution (code 0)' contains 'Cannot connect to "tcp://nothinghere:8080": php_network_getaddresses: getaddrinfo for nothinghere failed: Name or service not known (code 0)'.

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the fix-behaviour-when-icap-client-cannot-connect-to-socket branch from 1be7cf5 to 98dcef3 Compare August 12, 2024 17:44
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the fix-behaviour-when-icap-client-cannot-connect-to-socket branch from 445ae88 to 6871a8a Compare August 12, 2024 17:54
@icewind1991 icewind1991 merged commit 1d77c62 into nextcloud:master Aug 12, 2024
49 of 52 checks passed
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants