-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get proper errer message when the connection to an ICAP Server fails #365
Get proper errer message when the connection to an ICAP Server fails #365
Conversation
this is in response [to this thread](https://help.nextcloud.com/t/error-when-try-a-save-profile-settings-when-changing-settings-for-antivirus-when-using-an-icap-profile/199787/2). Previous Behaviour: When the client was not able to connect the stream was not set, resulting in an error when calling the socket_set_timeout function. Changed Behaviour: When the is not able to connect the RuntimeException will be thrown with proper ErrorMessage and ErrorCode. Signed-off-by: Version Bot <[email protected]>
Is there something that still hast to be done by me? |
The lint test is failing due to formatting and at least one of the unit tests I sampled is failing due to a difference in the error output in the new test in this PR:
|
Signed-off-by: Robin Appelman <[email protected]>
1be7cf5
to
98dcef3
Compare
Signed-off-by: Robin Appelman <[email protected]>
445ae88
to
6871a8a
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
this is in response to this thread.
Previous Behaviour: When the client was not able to connect the stream was not set, resulting in an error when calling the socket_set_timeout function.
Changed Behaviour: When the is not able to connect the RuntimeException will be thrown with proper ErrorMessage and ErrorCode.