Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud 28 support #298

Closed
cocanut opened this issue May 15, 2023 · 36 comments
Closed

nextcloud 28 support #298

cocanut opened this issue May 15, 2023 · 36 comments
Labels

Comments

@cocanut
Copy link

cocanut commented May 15, 2023

The upgrade to Nextcloud 26 is currently not supported (i.e. stated by the web-updater) by this app (maximum Nexcloud version 25). Is there a plan/idea to support Nextcloud 26?

@ml31415
Copy link

ml31415 commented May 18, 2023

The same sad story as with the last version updates :-(

Referring to the last comments in #260 :

@aaronhuggins would you still be interested in helping out with maintenance of this package?

@icewind1991 could you please, please reconsider adding another maintainer - maybe @aaronhuggins - for this project, in order to improve the update situation?

For a ton of rather small installations out there this package is really important. And it's probably a good time right now to accept help from the community in order to maintain it.

@cocanut
Copy link
Author

cocanut commented May 20, 2023

I changed line 39 in "apps/documentserver_community/appinfo/info.xml" to

<nextcloud min-version="21" max-version="26"/>

Then i updated nextcloud via the command line updater to version 26.0.1. So far everything seems to work.

@hardingt
Copy link

Would like to add my voice here: For all it's bugs, it serves a useful purpose for those households and businesses wanting to get away from the big name providers (and all the baggage they bring with them). @icewind1991 please reconsider adding another maintainer to improve the update situation.

@aaronhuggins
Copy link
Collaborator

@ml31415 I would still be interested in helping with maintaining this. My maintenance cycle would be reactive, though, as it would be some time after I needed a newer OnlyOffice or Nextcloud version. Which just happened again and I'll be opening a PR some time in the next week. 🤦 I'm seeing all y'alls comments now! 🤷

@icewind1991 Would you be willing to make me a collaborator on this? What all would you need from me to have the confidence for that?

@hardingt
Copy link

hardingt commented Aug 15, 2023

It's now August, I see that https://github.com/ONLYOFFICE/onlyoffice-nextcloud still gets updates, now on 7.9 and 8.2, I'm confused how LinneyS seems to keep that repo up to date but doesn't push this one as well. I'm probably missing something basic about the relationship of the document server and Only Office. Another AT to @icewind1991 , @aaronhuggins appears to be willing to take up the mantel!

@ml31415
Copy link

ml31415 commented Aug 15, 2023

@ChristophWurst is there someone from the nextcloud core devs, who could delegate the maintenance of this package either to @aaronhuggins or someone else who'd like to take care of it with some more diligence?

@ChristophWurst
Copy link
Member

I'll ask internally

@chadek
Copy link
Collaborator

chadek commented Sep 7, 2023

I just "accidentally" updated to nextcloud 27 few weeks ago so I cannot use this plugin anymore for now :'( Does someone (@aaronhuggins ?) work on upgrading on 26 and or 27? If so, even if it is still draft, can one open a PR to help contribute to this and be able to manual install while it'd be accepted by the maintainer? I'm php newbee but I'd be happy to give a hand to this as it is useful for many.

@ml31415
Copy link

ml31415 commented Sep 7, 2023

@ChristophWurst any results?

@oujonny
Copy link

oujonny commented Oct 1, 2023

I would love to see this project alive again! I'm also in to submit PRs in Future!

@chadek
Copy link
Collaborator

chadek commented Oct 5, 2023

I opened this PR which at least allow to use onlyoffice on nextcloud 27 :) Any help to bump up the document_server version to latest is welcome.

@ml31415
Copy link

ml31415 commented Nov 11, 2023

So nextcloud 28 is about to come out and we still talk about proper 26 support ...
@ChristophWurst @AndyScherzinger @blizzz is there really nobody in all nextcloud, who could delegate this package to new caring and responsible hands?

@AndyScherzinger
Copy link
Member

Sorry for the wait 🙏
This seems to have been gotten lost to do since we discussed it and decided to hand it over.

So for starters I added @chadek and @aaronhuggins to the repo. Just let me know if that is sufficient or if you need other things to be done.

Again sorry for the wait, this definitely slipped through on my end 😞

@chadek
Copy link
Collaborator

chadek commented Nov 12, 2023

Thks @AndyScherzinger I just merged and release v0.1.14 to support nextcloud 27. This issue should be resolve. @ml31415 you try it out and tell me if it work properly?

I could not update onlyoffice higher than 7.2 because of a change into onlyoffice bundle which need more attention to be resolve. Any help is welcome (@aaronhuggins ?). I'll put more detail on the related issue

@aaronhuggins
Copy link
Collaborator

Hi @AndyScherzinger and @chadek! Thanks for the add and the release! I was trying to get updated OnlyOffice working a while ago and had some notes on it. I'll take a crack at updated binaries in the near future, but no promises as my holiday season is very busy.

@ml31415
Copy link

ml31415 commented Nov 12, 2023

@chadek Take your time with updating the binaries. As long as the status quo works for recent nextcloud version, which as far as I can tell works, I guess the most important thing is to get the recent versions marked as supported, so that everyone out there can happily update nextcloud itself without warnings due to incompatible versions / outdated dependencies.

So for the 0.1.14 release to show up in the market at https://apps.nextcloud.com/apps/documentserver_community I guess you'd need to add a fully built documentserver_community.tar.gz to the release assets, like in the previous releases.

@chadek
Copy link
Collaborator

chadek commented Nov 13, 2023

I have uploaded the asset but it still need to be publish on the app store. I'm new to all of this and it seams that I cannot publish the asset on app store as I'm not the actual owner of the app. Maybe I could setup a github action to automate that and @icewind1991 could provide a valid token to automatically publish on new release ?

@AndyScherzinger
Copy link
Member

I expect we need to transfer the app to you (app store account) and need to create a new set of keys for you.

@chadek
Copy link
Collaborator

chadek commented Nov 13, 2023

That is what I just found out reading the doc, the assets does not come with the expected signature

@chadek
Copy link
Collaborator

chadek commented Nov 13, 2023

So @AndyScherzinger how shall I proceed? I created an account in the app store using the github sso so it shall be the same username.

@kn0wmad
Copy link

kn0wmad commented Jan 31, 2024

Is this still in motion? Would love to see this available for current versions of Nextcloud

@AndyScherzinger
Copy link
Member

@chadek due to the late stability comment this issue came up on my radar again.
Is there still something open regarding the app store? Didn't check since I am currently on the phone, so commenting here was just a lot easier thank trying to check the app store.

@chadek
Copy link
Collaborator

chadek commented Jan 31, 2024

So @AndyScherzinger how shall I proceed? I created an account in the app store using the github sso so it shall be the same username.

@AndyScherzinger I am still waiting for an answer to this... It is quite far now, but as I remember, I created an account on the app store and I'm now waiting for you/someone to transfer the app to me if it is how it works : I'm new with the use of such store and have no clue of the workflow.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 1, 2024

Thanks for the info, I'll see what needs to be done 👍

@chadek
Copy link
Collaborator

chadek commented Feb 1, 2024

Thanks! Hopefully we can move forward!

@AndyScherzinger
Copy link
Member

I got a better picture. For you to be able we'll need to transfer the signing key to you, so you are able to release new versions or need to create a new one.

First step will the best be to remove icewind as a maintainer than add you where you will need to proof ownership using the key for a signing, than you will have taken over the app appstore wise.

We meet next week in person in the office and can than clarify things.

Could you drop me an email until then, so I have your contact for the key?

Andy dot Scherzinger at Nextcloud dot com

@AndyScherzinger
Copy link
Member

Along very sorry for the delay. This totally slipped through on my end 😔

@chadek
Copy link
Collaborator

chadek commented Feb 5, 2024

Preparing ground #314 to quickly update in the future

@chadek chadek changed the title nextcloud 26 support nextcloud 28 support Feb 5, 2024
This was referenced Feb 5, 2024
@chadek
Copy link
Collaborator

chadek commented Feb 5, 2024

Finally pushed to the app store! Waiting some feedbak here before closing

@chadek
Copy link
Collaborator

chadek commented Feb 5, 2024

@AndyScherzinger I did pushed a github action workflow to easily deploy. I just don't have access to project settings to set up secrets. If we want to go this way, I'll open a new issue to discuss that

@ChristophWurst
Copy link
Member

I just don't have access to project settings to set up secrets.

Please be careful with that and see https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/release_automation.html.

@chadek
Copy link
Collaborator

chadek commented Feb 6, 2024

@ChristophWurst I already used this. I actually pushed latest version to app store using the workflow in master from my fork to be able to push to app store. Now my point is whether I keep on publishing with my fork (which is not a good idea as the asset pushed on the app store would point to my repo and not the project repo) or somebody setup here secrets to deploy from this repo, setting up carefully reviews and being really careful when manipulating secrets.

@ChristophWurst
Copy link
Member

If you bring the automation over to this repo, environment secrets are the only way to go. Repository secrets are not secure.

@chadek
Copy link
Collaborator

chadek commented Feb 6, 2024

Yes totally right, sorry for that, I did not pay attention to the scope of both. Here is a pr to fix that if you mind take a look.

@chadek
Copy link
Collaborator

chadek commented Feb 20, 2024

@ChristophWurst if it is all good now, maybe someone can setup environment secrets.

Copy link

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 60 days. Thank you for your contribution!

Retaking repo management include inheritance of old, not treated, and probablty obsolete issues, this is why it was decided to mark issues as stale.

@github-actions github-actions bot added the stale label Nov 18, 2024
@chadek chadek closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants