Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky tests prevent pushing images - latest Dockerfile does NOT reflect latest Nextcloud Update from 27.1.3 to 27.1.4 #2104

Closed
henningsieh opened this issue Nov 25, 2023 · 10 comments

Comments

@henningsieh
Copy link

henningsieh commented Nov 25, 2023

Hi.

The latest master branch only contains the previous version 27.1.3
=> see master Dockerfile here: 4c24a2a#diff-ba531c54643576be3aab1b9c8dd47b669d4a27f024512ecb1506cae5ec6b61bf

The Update has been commited yesterday.
=> see commited/updated Dockerfile here: 44e01e1#diff-ba531c54643576be3aab1b9c8dd47b669d4a27f024512ecb1506cae5ec6b61bf

So, the commited update hasn't found its way into the master branch and/or is NOT included in the official Nextcloud Image on Docker Hub.

So docker-compse does no nextcloud-27.1.4 update, because 'latest' still refers to 27.1.3.

Do I miss or missunderstand somthing in general here?

Thanks in advance (and sorry, if it's not an issue but a noob question!)

@martadinata666
Copy link

Because it has flaky test https://github.com/nextcloud/docker/actions/runs/6985847840 that prevent pushing images.

@henningsieh
Copy link
Author

Because it has flaky test ...

Hey, thanks for pointing that out to me.... My research didn't go that far. 🙏

@l0drex
Copy link

l0drex commented Nov 25, 2023

I just tried to update Nextcloud through the web ui, but got a 404 when trying to open the updater. Is that expected? Am I supposed to only do updates with docker compose?

@henningsieh
Copy link
Author

henningsieh commented Nov 26, 2023

just tried to update Nextcloud through the web ui, but got a 404 when trying to open the updater

Yes, here too.

If I remember correctly, this seems to be the NORMAL BEHAVIOR when running Nextcloud as a Docker image.

In the past, I could always use the "docker-compose" routines to start an updated Nextcloud after deleting the old image and container. (Or in my case use the Portainer frontend as you can see here).

I wonder, if waiting "is enough" in this case and if someone is fixing the flaky tests in CI/CD, so that the updated images get shipped? 🤔

At the moment the newest Nextcloud Image on Docker Hub is still "ENV NEXTCLOUD_VERSION=27.1.3". ☹️

@henningsieh henningsieh changed the title The latest Dockerfile in the official Image does not contain the Nextcloud Update from 27.1.3 to 27.1.4 flaky tests prevent pushing images - latest Dockerfile in official Image does NOT reflect latest Nextcloud Update from 27.1.3 to 27.1.4 Nov 26, 2023
@henningsieh henningsieh changed the title flaky tests prevent pushing images - latest Dockerfile in official Image does NOT reflect latest Nextcloud Update from 27.1.3 to 27.1.4 flaky tests prevent pushing images - latest Dockerfile does NOT reflect latest Nextcloud Update from 27.1.3 to 27.1.4 Nov 26, 2023
@henningsieh
Copy link
Author

henningsieh commented Nov 28, 2023

Hello.

I really don't know what's going on here (sorry!), but as of now there's only one faulty test left: 27.1.4-apache (i386) failed

27.1.4-apache (i386)
Process completed with exit code 1.

images-test-summary
Process completed with exit code 1.

Hopefully all images get pushed to Docker Hub after the next run, if all tests went fine!?

@Strit
Copy link

Strit commented Nov 28, 2023

It's been a couple of months since the action has completed successfully. I hope someone is looking into fixing what's wrong.

@pgassmann
Copy link

All the other test have the same error messages, but exit with success: https://github.com/nextcloud/docker/actions/runs/7012426462/job/19076931026

the postgres database is not set up sucessfully for the tests.

Installing with PostgreSQL database
=> Searching for scripts (*.sh) to run, located in the folder: /docker-entrypoint-hooks.d/pre-installation
Starting nextcloud installation
PostgreSQL username and/or password not valid
 -> You need to enter details of an existing account.
 
 ...
Trace: #0 /var/www/html/lib/private/Setup.php(356): OC\Setup\PostgreSQL->setupDatabase('test_26703')
Doctrine\DBAL\Exception: Failed to connect to the database: An exception occurred in the driver: SQLSTATE[08006] [7] connection to server at "db" (172.17.0.2), port 5432 failed: FATAL:  database "test_12362_db" does not exist`

@martadinata666
Copy link

martadinata666 commented Nov 28, 2023

So curious about previous image updates like this one https://github.com/nextcloud/docker/actions/runs/6979766289/job/18993721739 all green but the log got many database connection failures, technically I don't know what is success criteria is, I thought triple database installation/deployment test. But seems not it or intended too but not really working.

@donkeyDau
Copy link

27.1.4 is available now. Even though it does not show up on the README but on the recent tags:

image

@henningsieh
Copy link
Author

Since the lastest images build run seems to have been successful, I am closing this issue.

2023-12-04_11-25-05_Images · nextcloud_docker@d1dbc77 – Mozilla Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants