Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle macOS File Provider module logs into main debug archive #7464

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Bundle macOS File Provider module logs into main debug archive #7464

merged 6 commits into from
Nov 22, 2024

Conversation

claucambra
Copy link
Collaborator

Removes need for users to create the debug logs separately for macOS VFS

@claucambra claucambra self-assigned this Nov 5, 2024
@claucambra claucambra force-pushed the bugfix/debug-archive-aio branch from 73f1381 to 87aeaad Compare November 5, 2024 08:34
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra force-pushed the bugfix/debug-archive-aio branch from 87aeaad to 093accc Compare November 5, 2024 08:42
@claucambra claucambra added this to the 3.14.5 milestone Nov 6, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
mgallien
mgallien requested changes Nov 19, 2024
View reviewed changes
src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
@claucambra claucambra requested a review from mgallien November 20, 2024 02:28
@Rello Rello removed the request for review from camilasan November 22, 2024 08:24
@claucambra claucambra force-pushed the bugfix/debug-archive-aio branch from 295950e to 1e59028 Compare November 22, 2024 08:32
@claucambra @mgallien
Directly bundle macOS vfs logs within standard debug archive
e783539 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @mgallien
Remove create debug archive button from individual vfs account settings
a647b5f 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @mgallien
Ensure we are not halting the entire application when trying to gener…
580420c 
…ate the debug archive for macOS vfs

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @mgallien
Move debug archive for vfs creation out of log entry creation
9850434 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @mgallien
Just use davUser as account identifier for macOS log filename
3f0e75b 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @mgallien
Move file provider header include into file provider ifdef
a69a9a3 
Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the bugfix/debug-archive-aio branch from 1e59028 to a69a9a3 Compare November 22, 2024 09:08
@mgallien mgallien merged commit 14581d2 into master Nov 22, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/debug-archive-aio branch November 22, 2024 09:08
@backportbot backportbot bot mentioned this pull request Nov 22, 2024
Closed
3 tasks
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7464-a69a9a3064cf61504c41fb90fe721fa99e40b799-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @Rello