-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix login regression on linux #7455
Fix login regression on linux #7455
Conversation
8b5ddf2
to
986543a
Compare
/backport to stable-3.14 |
@claucambra @mgallien @camilasan could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Awesome, thanks @claucambra , could you please give an approval to start the workflows too? |
ab1d275
to
dfef7a6
Compare
dfef7a6
to
94f3d4d
Compare
@cmuck the AppImage is failing to build with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comment
@cmuck do you have any capacity to look at it on short notice? we are planning the next release this week and are very interested to put this one in. let us know... |
I'm on it |
2165ecd
to
c5392b5
Compare
I am trying this https://github.com/nextcloud/desktop/actions/runs/11954739882/job/33325545335?pr=7543 |
@cmuck could you remove the merge commit and rebase it? |
c5392b5
to
2455a65
Compare
2455a65
to
2d0f57f
Compare
2d0f57f
to
fe7bf88
Compare
@cmuck it is working now 🎉 |
fe7bf88
to
aacbc13
Compare
Okay, the Linux AppImage Package job definitely worked, now failing with ...
but the previous wget calls worked, maybe a hickup and re-run? Wondering why the required Windows Build and Test + SonarCloud analysis jobs failed since the PR does not touch anything related and the PR doesn't look to be in any relation with the error
Is there anything I can do so we proceed? |
@cmuck sonarcloud cannot run correctly for external clone of the main repository due to the need to access a secret that cannot be accessed from your clone |
aacbc13
to
0da6251
Compare
Signed-off-by: cmuck <[email protected]>
Signed-off-by: cmuck <[email protected]>
0da6251
to
410091c
Compare
Workaround for fixing #2573 and #7231
The workaround was introduced in 2022 by #4830 and recently (accidentally?) removed by #4584