Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login regression on linux #7455

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

cmuck
Copy link
Contributor

@cmuck cmuck commented Nov 4, 2024

Workaround for fixing #2573 and #7231

The workaround was introduced in 2022 by #4830 and recently (accidentally?) removed by #4584

@camilasan
Copy link
Member

Possible fix for #103 and #7231

@cmuck cmuck force-pushed the cm-fix-login-regression-on-linux branch 2 times, most recently from 8b5ddf2 to 986543a Compare November 5, 2024 18:36
@camilasan
Copy link
Member

/backport to stable-3.14

@cmuck
Copy link
Contributor Author

cmuck commented Nov 14, 2024

@claucambra @mgallien @camilasan could you please review this PR?

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmuck
Copy link
Contributor Author

cmuck commented Nov 15, 2024

Awesome, thanks @claucambra , could you please give an approval to start the workflows too?

@claucambra claucambra force-pushed the cm-fix-login-regression-on-linux branch from ab1d275 to dfef7a6 Compare November 18, 2024 01:34
@camilasan camilasan force-pushed the cm-fix-login-regression-on-linux branch from dfef7a6 to 94f3d4d Compare November 18, 2024 13:04
@camilasan
Copy link
Member

camilasan commented Nov 18, 2024

@cmuck the AppImage is failing to build with:

+ appimagetool -n ./squashfs-root Nextcloud_Desktop-x86_64.AppImage
./admin/linux/build-appimage.sh: line 100: appimagetool: command not found

@Rello Rello added this to the 3.15.0 milestone Nov 19, 2024
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment

admin/linux/build-appimage.sh Outdated Show resolved Hide resolved
@Rello
Copy link
Contributor

Rello commented Nov 20, 2024

@cmuck do you have any capacity to look at it on short notice? we are planning the next release this week and are very interested to put this one in. let us know...

@cmuck
Copy link
Contributor Author

cmuck commented Nov 21, 2024

I'm on it

@cmuck cmuck force-pushed the cm-fix-login-regression-on-linux branch from 2165ecd to c5392b5 Compare November 21, 2024 13:50
@camilasan
Copy link
Member

@cmuck cmuck requested a review from mgallien November 21, 2024 14:03
@camilasan
Copy link
Member

@cmuck could you remove the merge commit and rebase it?

admin/linux/build-appimage.sh Outdated Show resolved Hide resolved
@cmuck cmuck requested a review from camilasan November 21, 2024 15:42
@cmuck cmuck force-pushed the cm-fix-login-regression-on-linux branch from 2d0f57f to fe7bf88 Compare November 21, 2024 15:50
@camilasan
Copy link
Member

@cmuck it is working now 🎉
thank you so much!

@mgallien mgallien force-pushed the cm-fix-login-regression-on-linux branch from fe7bf88 to aacbc13 Compare November 21, 2024 17:01
@cmuck
Copy link
Contributor Author

cmuck commented Nov 21, 2024

Okay, the Linux AppImage Package job definitely worked, now failing with ...

2024-11-21T17:30:10.5097181Z Resolving github.com (github.com)... failed: No address associated with hostname.
2024-11-21T17:30:10.5100558Z wget: unable to resolve host address 'github.com'

but the previous wget calls worked, maybe a hickup and re-run?

Wondering why the required Windows Build and Test + SonarCloud analysis jobs failed since the PR does not touch anything related and the PR doesn't look to be in any relation with the error

ERROR: Error during SonarScanner execution
ERROR: Project not found.

Is there anything I can do so we proceed?

@mgallien
Copy link
Collaborator

@cmuck sonarcloud cannot run correctly for external clone of the main repository due to the need to access a secret that cannot be accessed from your clone
the windows CI was failing and I fixed it yesterday
thanks for the help and your contribution
very much appreciated

@mgallien mgallien force-pushed the cm-fix-login-regression-on-linux branch from aacbc13 to 0da6251 Compare November 22, 2024 09:15
@mgallien mgallien force-pushed the cm-fix-login-regression-on-linux branch from 0da6251 to 410091c Compare November 22, 2024 10:13
@mgallien mgallien merged commit bc4001d into nextcloud:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 3.14.x asks to log in on every start Client needs to manually login after every start
5 participants