Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release kind detection #7031

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix release kind detection #7031

merged 1 commit into from
Aug 27, 2024

Conversation

ivaradi
Copy link
Contributor

@ivaradi ivaradi commented Aug 27, 2024

The changes last made to the Ubuntu/Debian build scripts do not work well on the stable branches, as it is not detected properly if we are dealing with a release or not. This patch fixes this problem.

@ivaradi ivaradi requested review from claucambra and mgallien August 27, 2024 05:53
@ivaradi ivaradi enabled auto-merge (rebase) August 27, 2024 05:55
Signed-off-by: István Váradi <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7031-96abca232895f3e6b6ef5d544c79f804ed54d86b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Aug 27, 2024

@ivaradi ivaradi merged commit c1cee5b into master Aug 27, 2024
12 of 15 checks passed
@ivaradi ivaradi deleted the release_kind_fix branch August 27, 2024 13:50
@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 27, 2024

/backport to stable-3.13

@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 27, 2024

/backport to stable-3.14

Copy link

backportbot bot commented Aug 27, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/7031/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96abca23

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7031/stable-3.13

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Aug 27, 2024

The backport to stable-3.14 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.14
git pull origin stable-3.14

# Create the new backport branch
git checkout -b backport/7031/stable-3.14

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96abca23

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7031/stable-3.14

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 27, 2024

/backport to stable-3.14

Copy link

backportbot bot commented Aug 27, 2024

The backport to stable-3.14 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.14
git pull origin stable-3.14

# Create the new backport branch
git checkout -b backport/7031/stable-3.14

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96abca23

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7031/stable-3.14

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants