Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 🐧🪟 🍏 Make desktop clients look more native #6639

Closed
marcoambrosini opened this issue Apr 17, 2024 · 10 comments
Closed

💻 🐧🪟 🍏 Make desktop clients look more native #6639

marcoambrosini opened this issue Apr 17, 2024 · 10 comments
Assignees

Comments

@marcoambrosini
Copy link
Member

  • Introduce transparency
  • Adjust button style to be native (basic button look, only slight rounded corners, not pill-style, no color)

Curent Windows Other Windows example Proposed
Image Image

additional ideas:

  • adjust Font to use native font
  • also use default font sizes
  • add backdrop shadow
  • use monochrome icons instead of colorful ones?
  • use native icons if there are some
  • make search bar more round, e.g. like this: Image
  • make the dropdowns more rounded, look more native, e.g. like this: Image Image (also all items usually have icons)
  • the dropdown is usually rather 3 dots: Image Image
@camilasan
Copy link
Member

@tobiasKaminsky ^^

@ostasevych
Copy link

Have you tried to add showMainDialogAsNormalWindow=true key to the nextcloud.cfg file?

@marcoambrosini
Copy link
Member Author

Have you tried to add showMainDialogAsNormalWindow=true key to the nextcloud.cfg file?

This seems to only add a title bar to the window, which is not what we want, but thanks @ostasevych

@marcoambrosini
Copy link
Member Author

marcoambrosini commented Apr 22, 2024

To be defined in the 24/04 call

  • Qt6 upgrade: what will we get out of the box without changing anything?
  • Time, when will this upgrade happen
  • Which components would be native and which ones should we work on
  • What other input is needed from the design team
  • Design review call after Qt6 upgrade?

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Clients team Apr 23, 2024
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (max 2 entries / member) in 🤖 🍏 Clients team Apr 23, 2024
@marcoambrosini
Copy link
Member Author

Kickoff call outcome:

@claucambra will prepare a PoC of the client and strip down all custom styles.
Focus is on Mac and Windows for now.

Linux will have KDE styles for KDE and Material for the rest.

We'll review this in person during the company week. Exact date and time TBD

@camilasan
Copy link
Member

@claucambra will prepare a PoC of the client and strip down all custom styles.
Focus is on Mac and Windows for now.

I am guessing the PoC didn't happen yet or?

@claucambra
Copy link
Collaborator

@claucambra will prepare a PoC of the client and strip down all custom styles.
Focus is on Mac and Windows for now.

I am guessing the PoC didn't happen yet or?

it needs to be scheduled, I am currently assigned to macOS VFS related tasks

@camilasan
Copy link
Member

it needs to be scheduled, I am currently assigned to macOS VFS related tasks

So that is a no :) I am asking because I was assigned to it.

@camilasan
Copy link
Member

camilasan commented Jun 14, 2024

  • Before the idea was to remove all custom components and use Qt6 components to check how that would look (PoC).
  • After talking to @tobiasKaminsky yesterday and to @marcoambrosini today (June 14): we think the best approach is to start the project by focusing on smaller tasks (split the issue due to current work load):
    1. transparency
    2. use native font
    3. use native icons
    4. use native buttons
  • Now check what @jancborchardt thinks of it (?)
  • Next we finally move every custom component to Qt6 components.

@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (max 2 entries / member) to 🏗️ In progress in 🤖 🍏 Clients team Jun 26, 2024
@jancborchardt
Copy link
Member

After talking to @tobiasKaminsky yesterday and to @marcoambrosini today (June 14): we think the best approach is to start the project by focusing on smaller tasks (split the issue due to current work load):

  • transparency
  • use native font
  • use native icons
  • use native buttons

@camilasan yes, this is what I’ve been saying from the beginning, so I agree. :) See in the original issue:

Introduce transparency
Adjust button style to be native (basic button look, only slight rounded corners, not pill-style, no color)

@AndyScherzinger AndyScherzinger changed the title Make desktop clients look more native 💻 🐧🪟 🍏 Make desktop clients look more native Jul 12, 2024
@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Aug 6, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Clients team Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

No branches or pull requests

9 participants