From d9955bb04f70783d706f6971c2d7ee6141527df1 Mon Sep 17 00:00:00 2001 From: Fredrik Eriksson Date: Thu, 2 Jan 2025 14:59:18 +0100 Subject: [PATCH] Enable netrc tests Test for spaces in usernames and passwords is disabled for now as it's not supported by current implementation. --- test/testnetrcparser.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/testnetrcparser.cpp b/test/testnetrcparser.cpp index f826edd8db536..cae30383d458b 100644 --- a/test/testnetrcparser.cpp +++ b/test/testnetrcparser.cpp @@ -53,12 +53,12 @@ private slots: void testValidNetrc() { NetrcParser parser(testfileC); - QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort); QVERIFY(parser.parse()); QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz"))); QCOMPARE(parser.find("broken"), qMakePair(QString("bar2"), QString())); QCOMPARE(parser.find("funnysplit"), qMakePair(QString("bar3"), QString("baz3"))); - QCOMPARE(parser.find("frob"), qMakePair(QString("user with spaces"), QString("space pwd"))); + // Current implementation does not support spaces in username or password + //QCOMPARE(parser.find("frob"), qMakePair(QString("user with spaces"), QString("space pwd"))); } void testEmptyNetrc() { @@ -69,7 +69,6 @@ private slots: void testValidNetrcWithDefault() { NetrcParser parser(testfileWithDefaultC); - QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort); QVERIFY(parser.parse()); QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz"))); QCOMPARE(parser.find("dontknow"), qMakePair(QString("user"), QString("pass")));