Import from Trello

[vitormattos]

• Resolves: Export/import [$30] #87
• Target version: master

Summary

Command to import json from Trello boards to Deck.

PS: The import command is ready to accept import from other systems and not just Trello. To create import from other systems it will be necessary to create a class for the system to be imported.

Command help:

deck:import --help
Description:
  Import data

Usage:
  deck:import [options]

Options:
      --system=SYSTEM   Source system for import. Available options: Trello API, Trello JSON.
      --config=CONFIG   Configuration json file. [default: "config.json"]
      --data[=DATA]     Data file to import. [default: "data.json"]

API documentation
See docs/API.md

TODO

• Import flow
  • Import board
  • Import labels
  • Import stacks
  • Import cards
  • Associate cards to labels
  • Import comments
  • Import attachments. Attachment URL added in the attachment table;
  • Import user assigment
    • Relationship of Trello users to Nextcloud users
• Import systems
  • Import from Trello JSON (limited to 1000 Trello actions)
  • Import from Trello API (no data limits to import)
  • Implement architecture to make possible create an importer to other systems
• Implement endpoints to import using Deck API
  • Endpoint to import using API
  • Endpoint to get available systems to import
  • Endpoint to get json schema of a system to import

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required

[vitormattos]

Finally done!

Code coverage with tests is not ideal but I think it is acceptable.

The breaking tests are related to the setup of the server, it seems to me it has no relationship with this PR.

NOTE: It seems a good thing to remove support for PHP 7.2 and 7.3, I had to remove the beautiful arrow functions and heredoc.

[vitormattos]

Hi @juliushaertl,

I organized the code and I think it is now more beautiful and ready to accept other import sources.

I didn't implement the frontend in VueJS for importing but it already has the API endpoints ready to be consumed and working.

I thought about implementing Asana import but I've committed too much in this PR :-D

[juliusknorr]

First of all thanks a lot for your contribution, this is really awesome and looks very promising from a first quick look.

It might take a bit until I get to fully review it, but I'll dig into it in detail as soon as possible.

NOTE: It seems a good thing to remove support for PHP 7.2 and 7.3, I had to remove the beautiful arrow functions and heredoc.

We basically stick with what is compatible in the Nextcloud release, which is currently requiring 7.3 as a minimum PHP version. We can indeed drop 7.2 for any newer branch than stable1.2 which still needs it for Nextcloud 20.

[vitormattos]

@juliushaertl to make code review easier, I updated the documentation with the class diagram.

I used the extension yUML for the VSCode|Codium.

[vitormattos]

Hi @juliushaertl,

I returned to draft to implement import using Trello API.
It's ready for code review again, I updated the documentation too.

[julien-nc]

Great work!

Could you provide a test JSON file to import?

If I understand correctly, when importing from Trello API, all data is first loaded and stored in BoardImportTrelloApiService attributes. Once everything is loaded, Deck entities are added into the DB. I think there is a chance to reach the max RAM usage when importing big Trello projects.

I don't know how hard it would be to make those changes but: Would it be possible to import progressively while the data is loaded?
It would be very effective in saving RAM usage, even more thanks to the request pagination. Data could be added after each doRequest call.

[juliusknorr]

Rebased and resovled the composer.lock conflict

[juliusknorr]

Great work, thanks a lot @vitormattos 👏