Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Contact notes to Notes app #1293

Open
sunjam opened this issue Oct 4, 2019 · 7 comments
Open

Save Contact notes to Notes app #1293

sunjam opened this issue Oct 4, 2019 · 7 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request help wanted Extra attention is needed

Comments

@sunjam
Copy link

sunjam commented Oct 4, 2019

This casual request is for Contact notes to be accessible for viewing and editing within the Notes app.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 4, 2019

@korelstar, is there an easy way? :)
Is there an api for this? Ref the bookmark thread here: #1272

@korelstar
Copy link
Member

korelstar commented Oct 13, 2019

It depends on where the actual note should be saved. I see the following possibilities (see also nextcloud/notes#389 (comment)):

use existing attribute field in contact

Currently, the notes app uses files in order to save notes. This has to be extended by another storage-backend for notes in a contact. Such notes could be shown in a special category (e.g. "Contacts"). Creating notes in that category from the notes app can't be possible due to the missing contact.

This approach requires some major changes in the notes app. Furthermore, the impact on the REST-API has to be evaluated.

link external note from contact

In this approach, the note is saved using existing means (I.e. a file in the file system). The notes app needs to provide an URI for creating and opening a new note (should be easy). But the contacts app has to manage the link from contact to the actual note. This could be done by saving the note's id in the contact's note field together with a special marker that indicates, that the note is saved externally.

Issues have to be solved for use-cases like deleting a contact (linked note should be deleted, too) and opening the linked contact from notes app. Furthermore, the note's content is not editable anymore from another contacts app (e.g. the contacts app on your smartphone).

edit in text-app instead

Another possibility would be to not connect contacts app and notes app, but open contact's notes in the new text editor. The notes app will also use that editor in the future, so you will have the same markdown editor across apps. This should be the easiest approach. However, you don't have your contacts' notes directly in the notes app.

@skjnldsv
Copy link
Member

I think what OP wish is a way to export a note from a contact and directly open the notes app with the already filled text ?

@korelstar
Copy link
Member

Oh, then please clarify this issue, @sunjam !

@jancborchardt
Copy link
Member

Just like for "Save contact website" let’s keep it simple :) ( #1272 (comment) )

Design-wise:

  • Instead of the delete icon, we show a 3-dot menu with "Save to Notes" and "Delete" (of course only when Notes is installed)
  • "Save to Notes" simply saves it into the root Notes folder, no category or anything
  • Gives tooltip feedback saying "Saved to Notes [ Edit ]" in case people want to edit it.

That’s a simple first implementation. :)

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of help wanted Extra attention is needed and removed 0. Needs triage labels Jan 2, 2020
@brainchild0

This comment has been minimized.

@sunjam

This comment has been minimized.

@skjnldsv skjnldsv added this to the to plan milestone Sep 7, 2020
@ChristophWurst ChristophWurst removed this from the to plan milestone Sep 14, 2021
@joshtrichards joshtrichards changed the title [Feature Request] Save Contact notes to Notes app Save Contact notes to Notes app Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants