-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order imports alphabetically #10
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
I’m a bit sad to see that phpcs sides with phpstorm on this one and does not follow What there is an option for is wether special kind of import should be sorted separately, I would vote for using it and not mix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this
So like PSR12? Fine with that as well:
|
No, alpha sorting order, PSR12 seems to be none. |
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
@ChristophWurst I suppose we should tag a new release for this to be deployed on the other repos? |
It seems phpstorm does not sort the use statements the same way as sort, and other editors may do yet something else.
So I propose to force the order in the coding standard so that the diff make sense and we do not argue about the order.
Signed-off-by: Côme Chilliet [email protected]