Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs fixer v3.16 moves method braces to a new line #11

Closed
ChristophWurst opened this issue Apr 11, 2023 · 0 comments · Fixed by #12
Closed

cs fixer v3.16 moves method braces to a new line #11

ChristophWurst opened this issue Apr 11, 2023 · 0 comments · Fixed by #12
Labels
bug Something isn't working

Comments

@ChristophWurst
Copy link
Member

Ref nextcloud/mail#8334

 472) tests/HordeTranslationHandlerTest.php
      ---------- begin diff ----------
--- /home/runner/work/mail/mail/tests/HordeTranslationHandlerTest.php
+++ /home/runner/work/mail/mail/tests/HordeTranslationHandlerTest.php
@@ -23,16 +23,19 @@
 use ChristophWurst\Nextcloud\Testing\TestCase;
 use OCA\Mail\HordeTranslationHandler;
 
-class HordeTranslationHandlerTest extends TestCase {
+class HordeTranslationHandlerTest extends TestCase
+{
 	private $handler;
 
-	protected function setUp(): void {
+	protected function setUp(): void
+	{
 		parent::setUp();
 
 		$this->handler = new HordeTranslationHandler();
 	}
 
-	public function testT() {
+	public function testT()
+	{
 		$message = 'Hello';
 
 		$expected = $message;
@@ -41,7 +44,8 @@
 		$this->assertEquals($expected, $actual);
 	}
 
-	public function singularPluralDataProvider() {
+	public function singularPluralDataProvider()
+	{
 		return [
 			[0],
 			[1],
@@ -52,7 +56,8 @@
 	/**
 	 * @dataProvider singularPluralDataProvider
 	 */
-	public function testNgettext($number) {
+	public function testNgettext($number)
+	{
 		$singular = 'mail';
 		$plural = 'mails';
 

      ----------- end diff -----------

This shared config still uses the deprecated braces option https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/rules/basic/braces.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant