Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedded public calendar stylable #318

Closed
FirePowi opened this issue Jan 24, 2017 · 6 comments · Fixed by #926
Closed

Make embedded public calendar stylable #318

FirePowi opened this issue Jan 24, 2017 · 6 comments · Fixed by #926
Labels
3. to review Waiting for reviews enhancement New feature request
Milestone

Comments

@FirePowi
Copy link

FirePowi commented Jan 24, 2017

Wanted behaviour

Possibility to integrate a different CSS via iframe via something like « ?style=exemple.css » in the url of the iframe.

Actual behaviour

·The integrated iframe is really different (in design) than the website.
·It show some stuff that could be "flood" in some cases.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@georgehrke georgehrke changed the title [Feature request] Possibility to modify CSS for embedded calendars Make embedded public calendar stylable Jan 25, 2017
@law
Copy link

law commented Aug 1, 2017

Seconded, if it counts at all. Currently working with a website designer to display calendaring information via iCal, it is... painful and expensive. This feature would solve all of those problems.

@pixelipo
Copy link

pixelipo commented Aug 1, 2017

Shouldn't this be renamed to "Theming should apply to public calendar"? Would that be the solution to the issue?

Having a possiblity to add different custom CSS for each individual publicly shared calendar sounds like a maintenance hell and I would strongly "vote" against implementing such a "feature"

@law
Copy link

law commented Aug 1, 2017

maintenance hell from the user standpoint or the developer? As a user, I don't see how it would be different than 'per-folder settings' or some other 'reasonable defaults but easily-overrideable per-object' thing.

@pixelipo
Copy link

pixelipo commented Aug 1, 2017

Example: Version of nextcloud is updated to a newer version, all the custom CSS fails. If you have 20 custom CSS files you have to update all of them. Since they are also hardcoded in the URL, there's no way to tell how many people are accessing wrong ones.

Theming app is what is used to "personalize" one's Nextcloud installation.

If there is a missing "view" or a "feature" for the public calendar that can be added with simple CSS, why not create an issue here to discuss it? I really don't see the case for allowing totally custom stylesheets on public pages.

@georgehrke
Copy link
Member

Current idea for implementing this:

  • add special classes <div id="content" class="app-calendar" role="main">
    • app-calendar-public and app-calendar-public-embedded.

People who want to have custom styling can use the Custom CSS app and just add whatever styles they want.

@tcitworld Any comment? :)

@tcitworld
Copy link
Member

Just 👍

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request and removed enhancement-proposed labels Aug 25, 2019
@georgehrke georgehrke added this to the 2.0.0 beta1 milestone Aug 25, 2019
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 4, 2019
@georgehrke georgehrke mentioned this issue Oct 16, 2019
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants