Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice of 2 invalid options during make #1020

Closed
jancborchardt opened this issue Dec 20, 2018 · 3 comments
Closed

Notice of 2 invalid options during make #1020

jancborchardt opened this issue Dec 20, 2018 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Dec 20, 2018 •
edited by jospoortvliet
Loading

During make of latest master, the log contains this:

Invalid Option: Unexpected option value "false" for rule "no-descending-specificity"
Invalid Option: Unexpected option value "false" for rule "no-duplicate-selectors"

We should make sure that make runs through cleanly without any warnings or errors, even if they don’t break anything. :)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Dec 20, 2018
@georgehrke
Copy link
Member

Since #926 was merged, make works as expected again.

@jancborchardt
Copy link
Member Author

I only got these 2 test errors, unrelated to above but still issue during make:

 FAIL  js/vendor/jstzdetect/utilities/test.js
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at node_modules/@jest/core/build/TestScheduler.js:242:24
      at asyncGeneratorStep (node_modules/@jest/core/build/TestScheduler.js:131:24)
      at _next (node_modules/@jest/core/build/TestScheduler.js:151:9)
      at node_modules/@jest/core/build/TestScheduler.js:156:7
      at node_modules/@jest/core/build/TestScheduler.js:148:12
      at onResult (node_modules/@jest/core/build/TestScheduler.js:271:25)

Summary of all failing tests
 FAIL  js/vendor/jstzdetect/utilities/test.js
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at node_modules/@jest/core/build/TestScheduler.js:242:24
      at asyncGeneratorStep (node_modules/@jest/core/build/TestScheduler.js:131:24)
      at _next (node_modules/@jest/core/build/TestScheduler.js:151:9)
      at node_modules/@jest/core/build/TestScheduler.js:156:7
      at node_modules/@jest/core/build/TestScheduler.js:148:12
      at onResult (node_modules/@jest/core/build/TestScheduler.js:271:25)


Test Suites: 1 failed, 38 passed, 39 total

@georgehrke
Copy link
Member

Ah, js/vendor is an old folder from version 1.
Let me just delete the entire js/ folder on make

@georgehrke georgehrke mentioned this issue Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jancborchardt @georgehrke