Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deckimportfromtrello.csr #479

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

lucianpricop
Copy link
Contributor

I had to start all over, rebase failed with multiple conflicts.

Signed-off-by: Lucian Pricop <[email protected]>
@vitormattos
Copy link
Contributor

Hi @lucianpricop
Can you share here the URL of app source code's repository?

@lucianpricop
Copy link
Contributor Author

Hi @lucianpricop Can you share here the URL of app source code's repository?

Hi. Here it is https://github.com/newroco/DeckImportFromTrello

@vitormattos
Copy link
Contributor

Hi @lucianpricop
Maybe will be good if the name of repository is all lowercase or using _ to separate words.

For example:
deck_impor_tfrom_trello

Motivation:
When a new developer clone the repository inside the app or custom_app folder, the directory need to have the same name of app_id and will be more easy to work.

Consequences:
You will need put the app_id equal to repository name.

Only a suggestion.

Waiting for your opinion if you will maintain the current name or not to go to next step.

@lucianpricop
Copy link
Contributor Author

lucianpricop commented Mar 2, 2022

H. Very good suggestion, I renamed the repo https://github.com/newroco/deckimportfromtrello

@vitormattos
Copy link
Contributor

Hi @lucianpricop can you change your app_id to deck_import_from_trello and did an git commit --amend renaming the folder and the file of your csr file?

@vitormattos
Copy link
Contributor

vitormattos commented Mar 2, 2022

In time, I created commands, api and services into Deck to import boards from Trello to Deck but I don't created interface to do this, only created the commands. Maybe is a good idea to you contribute directly to Deck doing a PR with the interface, I can help you on API side that I created.

nextcloud/deck#3182

But... we need a new version of Deck to make this PR available to all.

@lucianpricop
Copy link
Contributor Author

Hi @lucianpricop can you change your app_id to deck_import_from_trello and did an git commit --amend renaming the folder and the file of your csr file?

No, it's better if I changed the repo to https://github.com/newroco/deckimportfromtrello

@lucianpricop
Copy link
Contributor Author

Sure, the minute I have some time.

@vitormattos
Copy link
Contributor

Do you want to revoke the last certificate (#441) and generate a new?

@lucianpricop
Copy link
Contributor Author

Yes, please, that other one was invalid.

@vitormattos
Copy link
Contributor

vitormattos commented Mar 3, 2022

CRT updated here: 65df7c4

@lucianpricop
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants