Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration 4 for file detail & new sharing #2676

Closed
wants to merge 5 commits into from

Conversation

AndyScherzinger
Copy link
Member

Iteration 1 can be found here: #2533 ☑️
Iteration 2 can be found here: #2573 ☑️
Iteration 3 can be found here: #2671

WiP for #2485 and collab with @tobiasKaminsky for adding commenting.

This PR/branch stack on top of fileDetails-3 until that one has been merged.

TODOs:

  • add comment box UI
  • send new comments to server (right away)
  • update activities list after comment has been send to server (async)
  • update activities list after comment could not be saved on server (error handling)

My idea behind the described to dos is to update the UI right away while reverting that in case the server couldn't store the comment. For starters I guess it'd be fine if it works synchronously to have it working and then improve upon that.

@tobiasKaminsky would you fancy taking on the part of client/server communication? ❤️

@tobiasKaminsky
Copy link
Member

I already have a branch for comments, which is in top of file versions.
To not have too much confusion, can you simply remove the comment part from here?

@AndyScherzinger
Copy link
Member Author

I already have a branch for comments, which is in top of file versions.
neither of these branches seems "visible" to me

To not have too much confusion, can you simply remove the comment part from here?
That is the only part of this PR, so you can just kill mine

On a general note
Why aren't the branches on GH plus opened PRs tagged as "1. developing"?

@tobiasKaminsky
Copy link
Member

They will come one by one, but I have to polish them a bit, before putting them public ;-)

@AndyScherzinger
Copy link
Member Author

terminated by any to come PR by @tobiasKaminsky

@AndyScherzinger AndyScherzinger deleted the fileDetails-4 branch June 4, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants