Iteration 4 for file detail & new sharing #2676
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration 1 can be found here: #2533 ☑️
Iteration 2 can be found here: #2573 ☑️
Iteration 3 can be found here: #2671
WiP for #2485 and collab with @tobiasKaminsky for adding commenting.
This PR/branch stack on top of
fileDetails-3
until that one has been merged.TODOs:
My idea behind the described to dos is to update the UI right away while reverting that in case the server couldn't store the comment. For starters I guess it'd be fine if it works synchronously to have it working and then improve upon that.
@tobiasKaminsky would you fancy taking on the part of client/server communication? ❤️