-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload list action icon for failed/pending uploads #3618
Comments
This comment has been minimized.
This comment has been minimized.
Well, the delete action (trashbin) is actually also just a cancel so. Shouldn't that also be the x-icon? |
Right, that’s fine. :)
What do you mean by that? Deleting a file? That’s not just removing an entry/notification, but an actual file. :) |
Not in the upload list... The it "deletes" the entry afaik. Cc @tobiasKaminsky |
I think we are talking about the same thing then and agree. :) What I mean is that in the above screenshot, the icon which is a trashbin should instead be an X. Because it only removes an entry in this upload list but does not delete an actual file. |
❤️ Yes, that's what we both meant 👍 |
Btw the clear all failed option is in the toolbar's menu atm which we would then remove (only menu entry atm). This can be tested in the current dev build. |
Nice improvement idea! |
Follow-up to #3472
After looking at it again I had the initial confusion of "But how do I retry a failed upload?" since only the delete action is so present.
We should instead have a 3-dot icon which includes both "Retry" and "Cancel" (and cancel using the x icon, not delete as it does not delete a file).
The text was updated successfully, but these errors were encountered: