Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications disabled for the wrong reason #3410

Closed
Zepmann opened this issue Dec 28, 2018 · 6 comments
Closed

Push notifications disabled for the wrong reason #3410

Zepmann opened this issue Dec 28, 2018 · 6 comments
Labels

Comments

@Zepmann
Copy link

Zepmann commented Dec 28, 2018

Actual behaviour

On an Android device without proprietary Google code and with all microG components installed, the Nextcloud Android application (installed through F-Droid) does not receive push notifications. In addition, the Notifications screen has the following message:

"Push notifications disabled due to dependencies on proprietary Google Play services."

The Nextcloud Android application from the Play Store (installed using a sideloaded APK) does not show this behavior. Push notifications work through microG.

Expected behaviour

Push notifications should work in the F-Droid release of the Nextcloud Android application, the same way as they do in the Play Store release. A check could be made for the availability of either Google's proprietary code or microG.

An example of an application that works correctly with Google's proprietary code and with microG is Signal.

Steps to reproduce

  1. Have an Android device without proprietary Google code ('GApps'), with microG installed. Make sure all checkmarks under 'Signature spoofing support' and 'Installed packages' are enabled in microG Settings.
  2. Install F-Droid. Install 'Nextcloud' through F-Droid.
  3. Open the Nextcloud application and login in your Nextcloud instance.
  4. Open the Notifications screen to see the mentioned message. Alternatively, try to authenticate another device with Nextcloud Notification two-factor authentication enabled. There will be no notification on the Android device.

Steps 3 and 4 can be repeated using the Play Store's APK when it is sideloaded. The result is that notifications work.

Environment data

Android version: 7.1.2

Device model: Xiaomi Mi 4c

Stock or customized system: LineageOS (without GApps)

Nextcloud app version: 3.4.1

Nextcloud server version: 5.0.0

@Zepmann Zepmann added the bug label Dec 28, 2018
@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #559 (Notifications), #3093 (wrong notification), #2315 (Wrong account displayed on notification), #2301 (Push notifications disabled due to depedencies on proprietary Google Play Services), and #3080 (Setting to disable new folder found notification).

@mario
Copy link
Contributor

mario commented Dec 28, 2018

This is unfortunately not possible yet as F-Droid cannot build with the required client side libraries. It will however change soon since Google is open sourcing the Firebase client push libs :) So stay tuned ;)

@Zepmann
Copy link
Author

Zepmann commented Dec 28, 2018

The current situation promotes APK downloading through shady websites to receive a fully working application, on devices that miss access to the Play Store. This seems undesirable from a security perspective, and should be fixed as soon as possible without relying on a third-party.

I would suggest to at least provide an unrestricted APK on the Nextcloud site itself, for those of us (un)fortunate enough to miss Google applications on their devices. Signal does this.

@mario
Copy link
Contributor

mario commented Dec 28, 2018

@Zepmann https://download.nextcloud.com/android/ is not very shady :)

@Zepmann
Copy link
Author

Zepmann commented Dec 28, 2018

Neither is it publicly/generally known. A link to there from the client download page would be appreciated. Of course, it does not have to be promoted with big letters. The Play Store should still be the primary download location. And F-Droid should be included on the page as soon as that version is equal to the Play Store version.

An additional suggestion: provide a copy/link to the latest version. Do not let the user select it if it is not needed/desired.

Thanks for the alternative, though. Really useful. :)

[edit]
Stupid me. There is a direct APK download link! Thanks for opening my eyes. :)

As the text file says in that directory, the latest releases can be found here.

I'll close this issue, since there is nothing fixable based on the original problem. Thanks!

@mario
Copy link
Contributor

mario commented Dec 28, 2018

Always happy to help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants