Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.0 - Roadmap #3371

Closed
46 of 47 tasks
tobiasKaminsky opened this issue Dec 14, 2018 · 17 comments
Closed
46 of 47 tasks

Release 3.5.0 - Roadmap #3371

tobiasKaminsky opened this issue Dec 14, 2018 · 17 comments

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Dec 14, 2018

Planned RC1: 28.01.19

Create stable-x.y branch & use it for release

  • create branch stable-3.5 (needed for backport bot)
    • make it protected
    • set up Codacy, Drone as required status
    • enable branch to be analyzed on codacy
  • change
    • drone.yml
    • getBranchName.sh
    • analysis-wrapper.sh

Bump

  • release new library version & use this is in app
  • Bump version name and version code in build.gradle files
  • Update CHANGELOG.md adding new features
  • check if code is outdated due to last supported server version @NextcloudServer annotation
  • bump version in MainApp
    • OUTDATED_SERVER_VERSION according server (e.g. NC12)
    • MINIMUM_SUPPORTED_SERVER_VERSION: latest supported version - 2 (e.g. NC12 -2 = NC10)
  • remove support for server older MINIMUM_SUPPORTED_SERVER_VERSION
  • add what's new slides

Test app with all supported Android version

  • access all activities
  • auto upload
  • upload / download files/folders
  • use external sdcard
  • what's new slides correctly shown on first start

All tests on

  • Android 4
  • Android 5
  • Android 6
  • Android 7
  • Android 8
  • Android 9

RC1

  • Verify that the new version number is shown in settings
  • Verify that logging is enabled
  • add $version.txt to /fastlane/metadata/android/en-US/changelogs/ to support GPlay version info
  • Tag new version as rc-3.5.0-01 with private dev key (not on github)
  • Build and release to Play Store as beta release and :shipit:
  • Publish it on f-droid as optional release: edit metadata and open new merge request on gitlab
  • Verify that it is shown on f-droid (within 24h)

RC2

  • Verify that the new version number is shown in settings
  • Verify that logging is enabled
  • add $version.txt to /fastlane/metadata/android/en-US/changelogs/ to support GPlay version info
  • Tag new version as rc-3.5.0-02 with private dev key (not on github)
  • Build and release to Play Store as beta release and :shipit:
  • Publish it on f-droid as optional release: edit metadata and open new merge request on gitlab
  • Verify that it is shown on f-droid (within 24h)

Final Release, after two weeks time (max) of latest RC release

  • replace screenshots (https://github.com/nextcloud/screenshots/tree/master/android/phone)
  • Verify that the new version number is shown in settings
  • Verify that logging is disabled
  • update translations from transifex
  • Test that what's new is shown correctly on upgrade
  • add $version.txt to /fastlane/metadata/android/en-US/changelogs/ to support GPlay version info
  • Tag new version as stable-3.5.0 with private dev key (not on github)
  • Build and release to Play Store as stable release and :shipit:
  • Publish it on f-droid as release: edit metadata, bump "current version" and open new merge request on gitlab
  • Verify that it is shown on f-droid (within 24h)
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jan 28, 2019

@tobiasKaminsky
Copy link
Member Author

RC2 released :shipit

@tobiasKaminsky
Copy link
Member Author

Tomorrow I'll do a RC3 with new library 1.3.1 and on Monday we can release final version.
D'accord @AndyScherzinger? :-D

@AndyScherzinger
Copy link
Member

The translations should then nevertheless be released with RC3 too. Just to see if somebody reports a problem with a translation. I am aware that this might enforce yet another translations cherry pick PR.

@tobiasKaminsky
Copy link
Member Author

Good point.

@tobiasKaminsky
Copy link
Member Author

3.5.0 final is releasead!

@MikeZuluUSA
Copy link

MikeZuluUSA commented Feb 13, 2019

Could not find any of these mentioned functions/features:

  • Option to not show notifications for new media folders
  • Add support for QR codes & deep links
  • Direct camera upload
  • Sync all downloaded

Any help?
S9 - up tp date version
nextcloud app - 3.5.0

@realrufans
Copy link

realrufans commented Feb 13, 2019

@MikeZuluUSA Same here .

3.5.0 says 99% complete.
@tobiasKaminsky says final release.

🤔

Edit: I did a fresh install. Didn't see any changes .

@tobiasKaminsky
Copy link
Member Author

https://play.google.com/store/apps/details?id=com.nextcloud.client
it is online, maybe it takes some time. All my devices are already updated.

You can verify if you go in the app -> settings and on botton you can see the version.

@realrufans 99% complete is because this issue is still open ;-)

@realrufans
Copy link

Yes . The version is updated but not the functions.

@danielb42
Copy link

Exactly. Since yesterday (evening)'s update version string is 3.5.0, just without any of the proposed functions.

@tobiasKaminsky
Copy link
Member Author

Could not find any of these mentioned functions/features:

  • Option to not show notifications for new media folders

This is shown as action in notification: #3448 (comment)

  • Add support for QR codes & deep links

This is shown on creating a new account:
2019-02-14-085826

  • Direct camera upload

Shown on "+":
2019-02-14-085851

  • Sync all downloaded

This is done in background, so you will only notice it, if you download a file, e.g. text file, change it on server and wait a bit (job is running every 15min on wifi only).

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 14, 2019

So if you hit the plus button in at the bottom in the main screen you don't see a menu item "Upload from camera" in the list? If you add a new account you don't see a qr code symbol on the screen where you put in the server address? If a new media folder notification comes up it doesn't have an action to deactivate them?

@danielb42
Copy link

@AndyScherzinger nevermind, Camera Upload and QR stuff is there. Nothing new on New Folder notification however, no new settings in NC or Android settings. Where exactly should I look out for that?

@AndyScherzinger
Copy link
Member

@danielb42 it is an action of the notification itself to hide these notifications. So you need to wait for the next new folder notification. After disabling it via the notification you can then re-enable it on the settings screen. The setting in there is only visible after hiding these notifications.

@danielb42
Copy link

danielb42 commented Feb 14, 2019

@AndyScherzinger alright! Seems like that workflow was just way too obscure for me. All good, thanks for the release!

@AndyScherzinger
Copy link
Member

Yeah, we have hidden it a bit since we consider hiding these notifications an edge case so we didn't want to give it a too prominent place in the app. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants