-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapping successful upload notification should open the details view directly #3111
Comments
Can I pick up this issue ? |
Hi @adikul30, welcome to Nextcloud! Yes, thanks for taking an interest and picking this one up 👍 |
This is only possible due to a short time span, when "succesfull upload" is shown. |
So, since upload successful is the standard case shouldn't we completely get rid of that notification then? @tobiasKaminsky @jancborchardt |
It is shown for ~2s, I am fine with either way… |
I tried to emulate the situation here and Yes the notification disappears as soon as you notice it. So, should I try to persist the notification and implement the detail view opening or do you plan to remove the notification and just show a toast or sound instead ? |
Depends on the feedback of @jancborchardt |
(@jancborchardt said, that we should not only ping him, but always @nextcloud/designers, so also pinging them) |
From UX it might make sense to keep the notification for a little longer. Imagine a user uploads a file, continues with something else during the upload happens and once finished, they can pick up with the finished upload to for example share the file then. |
It's a bit more complicated than that I'm afraid :/ I'd rather argue that the uploads view should also get a three dot menu to offer similar actions than the file list view, while the menu should then only be present for successfully uploaded files. Would that work as an alternative way to handle this? |
OK, in that case it makes no sense to keep the notification.
Yes, that sounds like a good improvement then. 👍 |
@tobiasKaminsky are you also fine with the latest approach discussed here? :) |
Am also fine with removing the notification! :) |
Hello Guys, can I work on this issue? |
Sure thing @joelselvaraj 👍 |
As per the decision here, I have created a pull request #3637 to remove the notification on successful uploads. Kindly review and let me know if any changes are required. |
As this is separate from this issue, we should split this up and discuss it: #3646 |
Fix #3111 - Remove upload success notification
Currently when you upload a file and then tap the notification to edit details, you are sent to the Uploads view.
That's not very useful – better would be to show the detail view of the file so you can add comments, share, rename etc.
The text was updated successfully, but these errors were encountered: