Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping successful upload notification should open the details view directly #3111

Closed
jancborchardt opened this issue Oct 4, 2018 · 18 comments

Comments

@jancborchardt
Copy link
Member

Currently when you upload a file and then tap the notification to edit details, you are sent to the Uploads view.

That's not very useful – better would be to show the detail view of the file so you can add comments, share, rename etc.

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #559 (Notifications), #2003 (Open notifications view of the correct account), #3105 (Notification 'Upload failed'), #2339 (Clean up "successful uploaded" section), and #311 (Finetune upload view).

@adikul30
Copy link

adikul30 commented Oct 6, 2018

Can I pick up this issue ?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Oct 6, 2018

Hi @adikul30, welcome to Nextcloud! Yes, thanks for taking an interest and picking this one up 👍

@tobiasKaminsky
Copy link
Member

This is only possible due to a short time span, when "succesfull upload" is shown.
Most of the time user will only see "upload in progress" and this cannot be redirected to file details view as it then does not yet exist on server.

@AndyScherzinger
Copy link
Member

So, since upload successful is the standard case shouldn't we completely get rid of that notification then? @tobiasKaminsky @jancborchardt

@tobiasKaminsky
Copy link
Member

It is shown for ~2s, I am fine with either way…

@adikul30
Copy link

adikul30 commented Oct 8, 2018

I tried to emulate the situation here and Yes the notification disappears as soon as you notice it. So, should I try to persist the notification and implement the detail view opening or do you plan to remove the notification and just show a toast or sound instead ?

@AndyScherzinger
Copy link
Member

Depends on the feedback of @jancborchardt
My vote is on removing the notification for 'uploaded successfully'

@tobiasKaminsky
Copy link
Member

(@jancborchardt said, that we should not only ping him, but always @nextcloud/designers, so also pinging them)

@juliusknorr
Copy link
Member

juliusknorr commented Oct 9, 2018

From UX it might make sense to keep the notification for a little longer. Imagine a user uploads a file, continues with something else during the upload happens and once finished, they can pick up with the finished upload to for example share the file then.

@AndyScherzinger
Copy link
Member

It's a bit more complicated than that I'm afraid :/
You'll see this notification per uploaded file, so when I upload several files at once via the multi select this success notification will get triggered per file, at least at the moment.
So. From my pov this notification in its current state isn't useful and keeping it a little longer won't help since it would then either get overwritten by the next successful file been uploaded or the notifications would simply pile up, which is then imho just noise to the user. :/

I'd rather argue that the uploads view should also get a three dot menu to offer similar actions than the file list view, while the menu should then only be present for successfully uploaded files. Would that work as an alternative way to handle this?

@juliusknorr
Copy link
Member

So. From my pov this notification in its current state isn't useful and keeping it a little longer won't help since it would then either get overwritten by the next successful file been uploaded or the notifications would simply pile up, which is then imho just noise to the user. :/

OK, in that case it makes no sense to keep the notification.

I'd rather argue that the uploads view should also get a three dot menu to offer similar actions than the file list view, while the menu should then only be present for successfully uploaded files. Would that work as an alternative way to handle this?

Yes, that sounds like a good improvement then. 👍

@AndyScherzinger
Copy link
Member

@tobiasKaminsky are you also fine with the latest approach discussed here? :)

@jancborchardt
Copy link
Member Author

Am also fine with removing the notification! :)

@joelselvaraj
Copy link

Hello Guys, can I work on this issue?

@AndyScherzinger
Copy link
Member

Sure thing @joelselvaraj 👍

@joelselvaraj
Copy link

As per the decision here, I have created a pull request #3637 to remove the notification on successful uploads. Kindly review and let me know if any changes are required.

@tobiasKaminsky
Copy link
Member

I'd rather argue that the uploads view should also get a three dot menu to offer similar actions than the file list view, while the menu should then only be present for successfully uploaded files. Would that work as an alternative way to handle this?

Yes, that sounds like a good improvement then.

As this is separate from this issue, we should split this up and discuss it: #3646

AndyScherzinger added a commit that referenced this issue Feb 19, 2019
Fix #3111 - Remove upload success notification
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.6.0 milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants