Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show if a file has comments #2908

Closed
Spartachetto opened this issue Aug 21, 2018 · 11 comments
Closed

Show if a file has comments #2908

Spartachetto opened this issue Aug 21, 2018 · 11 comments
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.

Comments

@Spartachetto
Copy link

Spartachetto commented Aug 21, 2018

Nextcloud app is constantly improving and the new versions will allow to insert comments and tags (#1798 and #548).

I Think it could be useful to display which files have comments and/or tags.

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #975 (Showing deleted files), #1756 (Show all text files), #276 (No files shown), #834 (Entering folder first time dont show files), and #983 (On device: show only folders containing downloaded files).

@AndyScherzinger
Copy link
Member

it could be useful to display which files have comments and/or tags.

looping in @nextcloud/designers and @nextcloud/android if and how this could be achieved

@AndyScherzinger AndyScherzinger added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Aug 22, 2018
@xXSTrikeXx
Copy link
Contributor

I like the tagging. But now it is useless, until you can use it also on the desktop client and mobil client.

@tobiasKaminsky
Copy link
Member

The web UI also does not show if a file/folder has a tag/comment.
As they (normally) have lots of more space than we have on mobile devices, I am not that sure, how we can solve this.

@juliusknorr
Copy link
Member

The web UI also does not show if a file/folder has a tag/comment.

We actually show a comments indicator if there is a new comment that mentions you on a file.

As they (normally) have lots of more space than we have on mobile devices, I am not that sure, how we can solve this.

There is nextcloud/server#6424 about showing tags in the files list, but I agree with @tobiasKaminsky that this won't work on mobile.

@tobiasKaminsky
Copy link
Member

Cool, didn't know that.
How is this done? Do we have to check on each and every file/folder for unread comments?

@juliusknorr
Copy link
Member

You can get it from the PROPFIND of the folder, if you request the oc:comments-unread property.

@Spartachetto
Copy link
Author

Spartachetto commented Aug 28, 2018

I was thinking to nextcloud/server#6424 when writing this issue. But @juliushaertl was faster than me at linking to it!

The mobile client could simply display somehow

  • if a file has unread comments
  • (maybe) if a file has tags.

If I am tagging the files in a folder, knowing if a file has tags could be practical. A simple non intrusive graphical sign could be enough. Maybe something as a light Gray dot.
It is not a problem if I need attention to notice it. Better that than having the need to click on the file to show the details.

@DerTomm
Copy link

DerTomm commented Jan 27, 2019

Today I wanted to create a first implementation attempt for this feature request (the 'show unread comments' part of it) as I really like to use this feature in the app too. But then I realized that in last December the necessary code changes were already commited by @tobiasKaminsky into master branch.

The way the feature is implemented looks really good and exactly meets my expectations. So I'd like to ask if there is already a plan when the changes will be merged into stable branch.

@AndyScherzinger
Copy link
Member

@DerTomm next release 3.5.0 might well get a first release candidate next week. So it should become a stable release within the next 2-3 weeks we hope.

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.5.0 milestone Jan 28, 2019
@tobiasKaminsky tobiasKaminsky changed the title Show if a file has tags or comments Show if a file comments Jan 28, 2019
@tobiasKaminsky
Copy link
Member

We have #2485 for discussing tag support.
So we can close this, I guess.

@Spartachetto Spartachetto changed the title Show if a file comments Show if a file has comments Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.
Projects
None yet
Development

No branches or pull requests

7 participants