Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcHeaderButton): Add a button only alternative for the header menu #6048

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 3, 2024

☑️ Resolves

This allows us to have one single place for styling the header actions, as currently the button-only variants use custom styles (unified search, assistent).

🖼️ Screenshots

Screenshot 2024-09-03 at 15-43-49 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: header-menu labels Sep 3, 2024
@susnux susnux added this to the 8.18.0 milestone Sep 3, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 3, 2024

/backport to next

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@susnux susnux force-pushed the feat/NcHeaderButton branch from 9af7d50 to 93eeaec Compare September 11, 2024 16:02
This allows us to have one single place for styling the header actions,
as currently the button-only variants use custom styles (unified search, assistent).

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the feat/NcHeaderButton branch from 93eeaec to a1142d5 Compare September 11, 2024 16:12
@susnux susnux merged commit 6ef1915 into master Sep 11, 2024
19 checks passed
@susnux susnux deleted the feat/NcHeaderButton branch September 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: header-menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants