fix(NcChip): adjust border radius to new design #5924
Conversation
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
added
3. to review
|
Should we really do this? The avatar is the main focus of the userbubble, at least from my point of view having it not rounded looks weird because of the now visible corners around the avatar |
| @@ -190,7 +190,7 @@ const onClose = () => { | |||
| <style scoped lang="scss"> | |||
| .nc-chip { | |||
| --chip-size: 24px; | |||
| --chip-radius: calc(var(--chip-size) / 2); | |||
| --chip-radius: var(--border-radius-small); | |||
There was a problem hiding this comment.
Does not work as this does not exist on Nextcloud 28 and 29, so the fallback to current design is needed.
|
Good point @susnux, then let's keep userbubble as is and only change chip |
ShGKme
added
bug
ShGKme
changed the title
|
TBH I also like chips in pills layout more. They are small and often have rounded avatar as user bubble, for example, when they are used to select users. |
|
They don't look ok when mixed up with other elements. |
Here on github it is pretty the same, GitHub is not rounded, maybe even less than our new design. Yet they use round chips for e.g. issue labels: Here you can see un-rounded UI elements next to the chips: |
|
All right, let's close |
🏚️ Before
🏡 After