Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcCheckboxRadioSwitch): adjust to new design #5923

Closed
wants to merge 2 commits into from
Closed

fix(NcCheckboxRadioSwitch): adjust to new design #5923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4400ed
Update border radius
marcoambrosini Aug 5, 2024
e81c160
Reduce border of radio set
marcoambrosini Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcCheckboxRadioSwitch/NcCheckboxContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export default {
gap: 4px;
user-select: none;
min-height: var(--default-clickable-area);
border-radius: var(--default-clickable-area);
border-radius: var(--border-radius-element);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fallback

padding: 4px calc((var(--default-clickable-area) - var(--icon-height)) / 2);
// Set to 100% to make text overflow work on button style
width: 100%;
Expand Down
4 changes: 2 additions & 2 deletions src/components/NcCheckboxRadioSwitch/NcCheckboxRadioSwitch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,13 +682,13 @@ export default {
color: var(--color-primary-element-light);
}

$border-radius: calc(var(--default-clickable-area) / 2);
$border-radius: var(--border-radius-element);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fallback

// keep inner border width in mind
$border-radius-outer: calc($border-radius + 2px);

&--button-variant.checkbox-radio-switch {
background-color: var(--color-main-background);
border: 2px solid var(--color-border-maxcontrast);
border: 1px solid var(--color-border-maxcontrast);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the variable with fallback instead

overflow: hidden;

&--checked {
Expand Down
Loading