fix(NcCheckboxRadioSwitch): adjust to new design #5923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
requested review from
szaimen,
susnux,
ShGKme,
GVodyanov and
Antreesy
marcoambrosini
added
enhancement
|
@ reviewers the switch component is still 44px tall and I can't find out why.. .Do you have any ideas? |
ShGKme
added
bug
ShGKme
changed the title
susnux
reviewed
Aug 5, 2024
| // keep inner border width in mind | ||
| $border-radius-outer: calc($border-radius + 2px); | ||
|
|
||
| &--button-variant.checkbox-radio-switch { | ||
| background-color: var(--color-main-background); | ||
| border: 2px solid var(--color-border-maxcontrast); | ||
| border: 1px solid var(--color-border-maxcontrast); |
There was a problem hiding this comment.
Use the variable with fallback instead
| @@ -682,13 +682,13 @@ export default { | |||
| color: var(--color-primary-element-light); | |||
| } | |||
|
|
|||
| $border-radius: calc(var(--default-clickable-area) / 2); | |||
| $border-radius: var(--border-radius-element); | |||
| @@ -198,7 +198,7 @@ export default { | |||
| gap: 4px; | |||
| user-select: none; | |||
| min-height: var(--default-clickable-area); | |||
| border-radius: var(--default-clickable-area); | |||
| border-radius: var(--border-radius-element); | |||
3 tasks
|
Sorry, I forgot about this PR when did #5974 But border width change is still actual, I only fixed border-radius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
Fixes #5875