Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcReferenceWidget): pass elements to intersection observer #5754

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(NcReferenceWidget): pass elements to intersection observer #5754

merged 1 commit into from
Jul 2, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jul 1, 2024 •
edited by susnux
Loading

☑️ Resolves

Intersection observer has observed elements as output

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added 3. to review Waiting for reviews regression Regression of a previous working feature labels Jul 1, 2024
@DorraJaouad DorraJaouad added this to the 8.14.0 milestone Jul 1, 2024
@DorraJaouad DorraJaouad requested review from susnux, ShGKme and Antreesy July 1, 2024 18:55
@DorraJaouad DorraJaouad self-assigned this Jul 1, 2024
@DorraJaouad DorraJaouad force-pushed the fix/intersection-observer branch from 23d82a3 to 1894fa6 Compare July 2, 2024 07:32
Antreesy
Antreesy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Screencast.from.02.07.2024.15.37.38.webm

Shall we keep ?? false as a fallback?

@Antreesy
Copy link
Contributor

Antreesy commented Jul 2, 2024

/backport to next

@Antreesy Antreesy requested a review from max-nextcloud July 2, 2024 13:41
@susnux
Copy link
Contributor

susnux commented Jul 2, 2024

/backport to next

@DorraJaouad DorraJaouad merged commit 62b8b36 into master Jul 2, 2024
19 checks passed
@DorraJaouad DorraJaouad deleted the fix/intersection-observer branch July 2, 2024 15:50
@backportbot backportbot bot mentioned this pull request Jul 2, 2024
Merged
@susnux susnux mentioned this pull request Jul 4, 2024
Merged
@susnux susnux added the bug Something isn't working label Jul 4, 2024
@susnux
Copy link
Contributor

susnux commented Jul 4, 2024

Please always add "bug" or "enhancement" labels if the PR is not a refactoring / chore / ci / test only PR

This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @Antreesy @susnux