-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Migrate SCSS $clickable-area
to CSS --default-clickable-area
#5694
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+554 Bytes
(110%)
...ull-starred_false-compact_true-header_image-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+211 Bytes
(100%)
...null-starred_false-compact_true-header_image-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(99%)
..._null-starred_false-compact_true-header_image-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...e_null-starred_false-compact_true-header_image-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+143 Bytes
(100%)
...null-starred_false-compact_true-header_none-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+362 Bytes
(100%)
..._null-starred_false-compact_true-header_none-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+267 Bytes
(100%)
...e_null-starred_false-compact_true-header_none-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+98 Bytes
(100%)
...me_null-starred_false-compact_true-header_none-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+554 Bytes
(110%)
...null-starred_null-compact_true-header_image-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+211 Bytes
(100%)
..._null-starred_null-compact_true-header_image-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(99%)
...e_null-starred_null-compact_true-header_image-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...me_null-starred_null-compact_true-header_image-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+554 Bytes
(110%)
..._null-starred_null-compact_true-header_none-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+211 Bytes
(100%)
...e_null-starred_null-compact_true-header_none-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(99%)
...me_null-starred_null-compact_true-header_none-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...ame_null-starred_null-compact_true-header_none-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+554 Bytes
(110%)
...null-starred_true-compact_true-header_image-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+211 Bytes
(100%)
..._null-starred_true-compact_true-header_image-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(99%)
...e_null-starred_true-compact_true-header_image-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+14 Bytes
(100%)
...me_null-starred_true-compact_true-header_image-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+159 Bytes
(100%)
..._null-starred_true-compact_true-header_none-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+390 Bytes
(100%)
...e_null-starred_true-compact_true-header_none-secondary_button-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+263 Bytes
(100%)
...me_null-starred_true-compact_true-header_none-secondary_none-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+124 Bytes
(100%)
...ame_null-starred_true-compact_true-header_none-secondary_none-editable_true.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+982 Bytes
(110%)
...rue-starred_false-compact_true-header_image-secondary_button-editable_false.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+693 Bytes
(100%)
...true-starred_false-compact_true-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-77 Bytes
(100%)
..._true-starred_false-compact_true-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...e_true-starred_false-compact_true-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+624 Bytes
(100%)
...true-starred_false-compact_true-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+858 Bytes
(110%)
..._true-starred_false-compact_true-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+668 Bytes
(100%)
...e_true-starred_false-compact_true-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+556 Bytes
(100%)
...me_true-starred_false-compact_true-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+982 Bytes
(110%)
...true-starred_null-compact_true-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+693 Bytes
(100%)
..._true-starred_null-compact_true-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-77 Bytes
(100%)
...e_true-starred_null-compact_true-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...me_true-starred_null-compact_true-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+982 Bytes
(110%)
..._true-starred_null-compact_true-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+693 Bytes
(100%)
...e_true-starred_null-compact_true-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-77 Bytes
(100%)
...me_true-starred_null-compact_true-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...ame_true-starred_null-compact_true-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+982 Bytes
(110%)
...true-starred_true-compact_true-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+693 Bytes
(100%)
..._true-starred_true-compact_true-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-77 Bytes
(100%)
...e_true-starred_true-compact_true-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...me_true-starred_true-compact_true-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+672 Bytes
(110%)
..._true-starred_true-compact_true-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+913 Bytes
(110%)
...e_true-starred_true-compact_true-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+630 Bytes
(100%)
...me_true-starred_true-compact_true-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+515 Bytes
(100%)
...ame_true-starred_true-compact_true-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+302 Bytes
(100%)
...ll-starred_false-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+149 Bytes
(100%)
...ull-starred_false-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(99%)
...null-starred_false-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+75 Bytes
(100%)
..._null-starred_false-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+143 Bytes
(100%)
...ull-starred_false-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+362 Bytes
(100%)
...null-starred_false-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+267 Bytes
(100%)
..._null-starred_false-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+98 Bytes
(100%)
...e_null-starred_false-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-57 Bytes
(99%)
...ull-starred_null-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
-120 Bytes
(99%)
...null-starred_null-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-59 Bytes
(99%)
..._null-starred_null-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(99%)
...e_null-starred_null-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+554 Bytes
(110%)
...null-starred_null-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+211 Bytes
(100%)
..._null-starred_null-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-92 Bytes
(99%)
...e_null-starred_null-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...me_null-starred_null-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+288 Bytes
(100%)
...ull-starred_true-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+170 Bytes
(100%)
...null-starred_true-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-73 Bytes
(99%)
..._null-starred_true-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+97 Bytes
(100%)
...e_null-starred_true-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+159 Bytes
(100%)
...null-starred_true-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+390 Bytes
(100%)
..._null-starred_true-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+263 Bytes
(100%)
...e_null-starred_true-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+124 Bytes
(100%)
...me_null-starred_true-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+348 Bytes
(100%)
...ue-starred_false-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+266 Bytes
(100%)
...rue-starred_false-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
...true-starred_false-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+197 Bytes
(100%)
..._true-starred_false-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+624 Bytes
(100%)
...rue-starred_false-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+858 Bytes
(110%)
...true-starred_false-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+668 Bytes
(100%)
..._true-starred_false-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+556 Bytes
(100%)
...e_true-starred_false-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-48 Bytes
(100%)
...rue-starred_null-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
-54 Bytes
(100%)
...true-starred_null-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-58 Bytes
(100%)
..._true-starred_null-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
-65 Bytes
(100%)
...e_true-starred_null-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+982 Bytes
(110%)
...true-starred_null-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+693 Bytes
(100%)
..._true-starred_null-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
-77 Bytes
(100%)
...e_true-starred_null-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...me_true-starred_null-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+347 Bytes
(100%)
...rue-starred_true-compact_false-header_image-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+272 Bytes
(100%)
...true-starred_true-compact_false-header_image-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
..._true-starred_true-compact_false-header_image-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+193 Bytes
(100%)
...e_true-starred_true-compact_false-header_image-secondary_none-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+672 Bytes
(110%)
...true-starred_true-compact_false-header_none-secondary_button-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+913 Bytes
(110%)
..._true-starred_true-compact_false-header_none-secondary_button-editable_true.png
Oops, something went wrong.
Binary file modified
BIN
+630 Bytes
(100%)
...e_true-starred_true-compact_false-header_none-secondary_none-editable_false.png
Oops, something went wrong.
Binary file modified
BIN
+515 Bytes
(100%)
...me_true-starred_true-compact_false-header_none-secondary_none-editable_true.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,7 +203,7 @@ $input-margin: 4px; | |
box-shadow: none; | ||
|
||
font-weight: normal; | ||
line-height: $clickable-area; | ||
line-height: var(--default-clickable-area); | ||
|
||
& > span { | ||
cursor: pointer; | ||
|
@@ -215,15 +215,15 @@ $input-margin: 4px; | |
min-height: 0; | ||
/* Keep padding to define the width to | ||
assure correct position of a possible text */ | ||
padding: #{math.div($clickable-area, 2)} 0 #{math.div($clickable-area, 2)} $clickable-area; | ||
padding: calc(var(--default-clickable-area) / 2) 0 calc(var(--default-clickable-area) / 2) var(--default-clickable-area); | ||
|
||
background-position: #{$icon-margin} center; | ||
background-size: $icon-size; | ||
} | ||
|
||
&:deep(.material-design-icon) { | ||
width: $clickable-area; | ||
height: $clickable-area; | ||
width: var(--default-clickable-area); | ||
height: var(--default-clickable-area); | ||
opacity: $opacity_full; | ||
|
||
.material-design-icon__svg { | ||
|
@@ -258,10 +258,10 @@ $input-margin: 4px; | |
|
||
// bottom-right corner | ||
position: absolute; | ||
right: $icon-margin + 1; | ||
right: calc($icon-margin + 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should get rid of this options in the future ( Just a note for the future, not related to this PR 😅 |
||
bottom: 1px; | ||
width: #{$clickable-area - $input-margin * 2}; | ||
height: #{$clickable-area - $input-margin * 2}; | ||
width: calc(var(--default-clickable-area) - $input-margin * 2); | ||
height: calc(var(--default-clickable-area) - $input-margin * 2); | ||
box-sizing: border-box; | ||
margin: 0; | ||
padding: 7px 6px; | ||
|
@@ -283,10 +283,10 @@ $input-margin: 4px; | |
color: inherit; | ||
border-color: var(--color-border-maxcontrast); | ||
|
||
min-height: #{$clickable-area * 2 - $input-margin * 2}; /* twice the element margin-y */ | ||
max-height: #{$clickable-area * 3 - $input-margin * 2}; /* twice the element margin-y */ | ||
min-height: calc(var(--default-clickable-area) * 2 - $input-margin * 2); /* twice the element margin-y */ | ||
max-height: calc(var(--default-clickable-area) * 3 - $input-margin * 2); /* twice the element margin-y */ | ||
// block width widening | ||
min-width: $clickable-area * 4; | ||
min-width: calc(var(--default-clickable-area) * 4); | ||
width: 100% !important; | ||
margin: 0; | ||
|
||
|
@@ -329,11 +329,11 @@ $input-margin: 4px; | |
// add the same bottomMargin as the right padding | ||
// for visual balance | ||
li:last-child > .action-text-editable { | ||
margin-bottom: $icon-margin - $input-margin; | ||
margin-bottom: calc($icon-margin - $input-margin); | ||
} | ||
|
||
// same for first item | ||
li:first-child > .action-text-editable { | ||
margin-top: $icon-margin - $input-margin; | ||
margin-top: calc($icon-margin - $input-margin); | ||
} | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because here we use it again