-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcReferenceList): Resolve relative URLs before fetching references #5272
Conversation
Resolve relative URLs and those without a location using `window.location` before fetching references for them. This fixes e.g. getting references for relative links to other pages in Collectives. Signed-off-by: Jonas <[email protected]>
/backport to next |
@Antreesy what do you mean with "if couldn't resolve a URL"? The links in your screenshot already look like full URLs, so they shouldn't get altered by the changes from this PR. Or are links to other calls inserted as absolute links without a location part in Talk? |
They're not, but new URL creates an object for every text, whether it has a link or not. I'm looking into how to fix that |
Ah, so the problem is that that Talk passes text that contains more than just an URL to NcReferenceList. In Text, we check first if the passed text is merely an URL and only pass it in this case. |
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
Resolve relative URLs and those without a location using
window.location
before fetching references for them. This fixes e.g. getting references for relative links to other pages in Collectives.🏁 Checklist
next
requested with a Vue 3 upgrade