-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcRichContenteditable): adjust styles and use CSS Modules to avoid global styles leak #5235
fix(NcRichContenteditable): adjust styles and use CSS Modules to avoid global styles leak #5235
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
/backport to next |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine now! Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and much cleaner!
(Funny how complex the webpack config is vs. no changes in the vite config^^)
Vite has pre-config for Rollup for "typical" bundling, but then you need to write your own plugin if you have something more special 😝 |
☑️ Resolves
NcRichContenteditable
has global CSS styles to style Tribute autocomplete. It works fine, until there are more than one version of those styles on the page. Styles should be scoped.@szaimen @hamza221 @JuliaKirschenheuter Could you please check it in your apps? The bug was not reproducible for me...
Screenshots
Note, there is no
data-v-<hash>
attrs in both cases.🚧 Tasks
scoped
doesn't work for non-component styles and doesn't truly scope from styles outside, having only one-way scoping)🏁 Checklist
next
requested with a Vue 3 upgrade