-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppSidebar): move focus to sidebar on open and auto return focus on close #5219
Merged
JuliaKirschenheuter
merged 4 commits into
master
from
fix/nc-app-sidebar--auto-return-focus
Feb 7, 2024
Merged
fix(NcAppSidebar): move focus to sidebar on open and auto return focus on close #5219
JuliaKirschenheuter
merged 4 commits into
master
from
fix/nc-app-sidebar--auto-return-focus
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
added
bug
Something isn't working
3. to review
Waiting for reviews
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
labels
Feb 7, 2024
ShGKme
requested review from
susnux,
raimund-schluessler,
JuliaKirschenheuter,
skjnldsv,
Pytal and
emoral435
February 7, 2024 00:47
Checking Cypress |
Pytal
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than minor comments, nice!
ShGKme
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Feb 7, 2024
4 tasks
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
…urn focus Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/nc-app-sidebar--auto-return-focus
branch
from
February 7, 2024 02:51
c719c88
to
6a9e2fa
Compare
|
JuliaKirschenheuter
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great! Thanks a lot!
ShGKme
changed the title
feat(NcAppSidebar): move focus to sidebar on open and auto return focus on close
fix(NcAppSidebar): move focus to sidebar on open and auto return focus on close
Feb 7, 2024
ShGKme
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Feb 7, 2024
Merged
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
bug
Something isn't working
feature: app-sidebar
Related to the app-sidebar component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
See description in commits.
Screenshots
On desktop
sidebar-focus-desktop.mp4
On mobile with focus-trap - also works
sidebar-focus-mobile.mp4
When sidebar was open, but a new file or tab was selected — focus is moved to the tab, and the element to return is updated
sidebar-focus-after-open.mp4
When the sidebar is initially open on page load - no focus move
sidebar-focus-on-load.mp4
Also works for apps
sidebar-focus-apps.mp4
🏁 Checklist