Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid closing all modals on escape if multiple are present #4677

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: Avoid closing all modals on escape if multiple are present #4677

merged 1 commit into from
Oct 20, 2023

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented Oct 20, 2023 •
edited
Loading

☑️ Resolves

Do not close all modals if escape is pressed while multiple layered modals are open, e.g. viewer and help dialog or filepicker from text

Steps to reprocuce:

  • Open a markdown file in viewer
  • Open the formatting help through the menu bar
  • Press Escape

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@juliusknorr juliusknorr mentioned this pull request Oct 20, 2023
Closed
1 task
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Oct 20, 2023
@juliusknorr juliusknorr requested a review from skjnldsv October 20, 2023 09:19
skjnldsv
skjnldsv approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@susnux susnux merged commit 32c7d04 into master Oct 20, 2023
14 checks passed
@susnux susnux deleted the bugfix/noid/escape-modal-multiple branch October 20, 2023 10:42
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @susnux @skjnldsv