fix: comments box overlapping #4163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <[email protected]>
solracsf
added
3. to review
ShGKme
reviewed
May 27, 2023
There was a problem hiding this comment.
I'm not sure this is a good way to fix overlapping. The fix should not change the size of the block.
And it breaks the cursor position in FF fixed by #3832
Maybe cut the text in a placeholder with an ellipsis?
Also, the default placeholder is truly too long now with :, @, and / commands. Maybe we can make it shorter or display it not in the placeholder.
|
Yeah, that PR introduced this. Text can be cutted of since there are essential informations on it. But, another way would be to:
|
4 tasks
|
Closing after nextcloud/server#40294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Fix #2027
🖼️ Screenshots
🏁 Checklist