Lazy load NcDatetimePicker in NcActionInput #4128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Patil <[email protected]>
pulsejet
force-pushed
the
pulsejet/actioninput
branch
from
405edf5 to
bec88fe
Compare
|
@pulsejet You need to reorder the imports to make eslint happy |
szaimen
requested review from
raimund-schluessler,
a team,
susnux,
nfebe and
szaimen
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for discussion at the current stage. Related nextcloud/server#38329
NcDatetimePickerdepends onNcTimezonePicker, which in turn depends on@nextcloud/calendar-js, which makes it bundle unnecessarily large. One solution is to lazy load this particular component only if needed.