Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular import of NcCheckboxRadioSwitch and NcCheckboxContent #4689

Closed
raimund-schluessler opened this issue Oct 23, 2023 · 0 comments · Fixed by #4691
Closed

Circular import of NcCheckboxRadioSwitch and NcCheckboxContent #4689

raimund-schluessler opened this issue Oct 23, 2023 · 0 comments · Fixed by #4691
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Milestone

Comments

@raimund-schluessler
Copy link
Contributor

After #4663 NcCheckboxRadioSwitch and NcCheckboxContent each import from each other. While this doesn't seem to be an issue for the vue 2 builds, it is the reason why the styleguide currently does not work in #4688.

I would propose to move these lines

export const TYPE_CHECKBOX = 'checkbox'
export const TYPE_RADIO = 'radio'
export const TYPE_SWITCH = 'switch'
export const TYPE_BUTTON = 'button'

into NcCheckboxContent and import the types from there.

@raimund-schluessler raimund-schluessler added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Oct 23, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Oct 23, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant