Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] Add title to Button component #3587

Closed
Tracked by #35654
ChristophWurst opened this issue Dec 21, 2022 · 1 comment
Closed
Tracked by #35654

[BITV] Add title to Button component #3587

ChristophWurst opened this issue Dec 21, 2022 · 1 comment
Assignees
@JuliaKirschenheuter
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button

Comments

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 21, 2022 •
edited
Loading

Problem

To show a tooltip on a button we currently use v-tooltip. An example can be found in https://github.com/nextcloud/nextcloud-vue/blob/69639353d5994d0decf96dd8d7f53bd559bdb809/src/components/NcAppSidebar/NcAppSidebar.vue#L242-L250. Another example is the files_sharing app: nextcloud/server#35654.

v-tooltip is not accessible and we want to migrate to native tooltips (title attribute) instead. An overview can be found in #2503.

Solution

Add a title prop to the Button component that will render as title attribute on the HTML element.
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button labels Dec 21, 2022
@ChristophWurst ChristophWurst mentioned this issue Dec 21, 2022
Closed
18 tasks
@ChristophWurst ChristophWurst changed the title Add title to Button component [BITV] Add title to Button component Dec 21, 2022
@ChristophWurst ChristophWurst mentioned this issue Dec 21, 2022
Merged
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 21, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 22, 2022
@JuliaKirschenheuter
Copy link
Contributor

https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcButton/NcButton.vue#L201-L202

NcButton will receive title attr via other attrs. No changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChristophWurst @JuliaKirschenheuter @szaimen