Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] "aria-labelledby" references an invalid element if there is a single tab #3032

Closed
danxuliu opened this issue Aug 13, 2022 · 0 comments · Fixed by #4736
Closed

[BITV] "aria-labelledby" references an invalid element if there is a single tab #3032

danxuliu opened this issue Aug 13, 2022 · 0 comments · Fixed by #4736
Assignees
@susnux
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component

Comments

@danxuliu
Copy link
Contributor

The aria-labelledby attribute must point to an element in the same document. In the AppSidebarTab it references its tab header, but when there is a single tab the tab headers are removed. Therefore, in that case the aria-labelledby should be replaced by aria-label with the tab name, which probably would require passing hasMultipleTabs (or something equivalent) to AppSidebarTab (which I do not know how to do :-) ) to set one or the other.
@danxuliu danxuliu added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 13, 2022
@susnux susnux changed the title "aria-labelledby" references an invalid element if there is a single tab [BITV] "aria-labelledby" references an invalid element if there is a single tab Nov 1, 2023
@susnux susnux mentioned this issue Nov 1, 2023
Merged
2 tasks
@susnux susnux self-assigned this Nov 1, 2023
@susnux susnux added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
2 participants
@susnux @danxuliu