Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar #14

Closed
ChristophWurst opened this issue Sep 4, 2018 · 6 comments
Closed

Avatar #14

ChristophWurst opened this issue Sep 4, 2018 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion

Comments

@ChristophWurst
Copy link
Contributor

As listed in #9, we need a standardized avatar component.

@juliushaertl @georgehrke @skjnldsv what should this look like?

IMO this should, for simple use cases, offer to display a colored single-letter avatar like the image placeholder jQuery plugin in server, but as a Vue component. Additionally, the component should allow custom URLs to images (on external servers).

@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Sep 4, 2018
@georgehrke
Copy link
Contributor

It should also allow to easily add the contacts-menu popover to the avatar. :)

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 4, 2018

Basically the same than we do for the popoverMenu but with the avatar built in?

We still pass the menu, but we also provide the url to the picture? Or should we use displayName/userId and design the component directly? I'm pretty fond of using a direct request to the server since we generate the avatar anyway.
I guess we can also support both, either you provide the url, or the displayName+uid?

@ChristophWurst
Copy link
Contributor Author

We still pass the menu, but we also provide the url to the picture? Or should we use displayName/userId and design the component directly? I'm pretty fond of using a direct request to the server since we generate the avatar anyway.
I guess we can also support both, either you provide the url, or the displayName+uid?

Sure, for internal avatars it would be easier to just do the URL magic internally. We just need a way to specify a custom URL for external avatars in Mail.

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 4, 2018

Just pass the url as a parameter then?
We should be able to use anything from gravatar to whatever else similar :p

@ChristophWurst
Copy link
Contributor Author

Just pass the url as a parameter then?

That's exactly what I had in mind (and wrote down above 😉).

@juliusknorr
Copy link
Contributor

IMO this should, for simple use cases, offer to display a colored single-letter avatar like the image placeholder jQuery plugin in server, but as a Vue component.

The placeholder avatars with letters are also images generated by the server from 14 on, so we should default to the avatar image from the server. If there is none, we can still generate one with some CSS styling.

👍 For adding an optional URL parameter to provide an external URL.

@skjnldsv skjnldsv added the component Component discussion and/or suggestion label Sep 7, 2018
@skjnldsv skjnldsv changed the title Comp: Avatar Avatar Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion
Projects
None yet
Development

No branches or pull requests

4 participants