-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar #14
Comments
It should also allow to easily add the contacts-menu popover to the avatar. :) |
Basically the same than we do for the popoverMenu but with the avatar built in? We still pass the menu, but we also provide the url to the picture? Or should we use displayName/userId and design the component directly? I'm pretty fond of using a direct request to the server since we generate the avatar anyway. |
Sure, for internal avatars it would be easier to just do the URL magic internally. We just need a way to specify a custom URL for external avatars in Mail. |
Just pass the url as a parameter then? |
That's exactly what I had in mind (and wrote down above 😉). |
The placeholder avatars with letters are also images generated by the server from 14 on, so we should default to the avatar image from the server. If there is none, we can still generate one with some CSS styling. 👍 For adding an optional URL parameter to provide an external URL. |
As listed in #9, we need a standardized avatar component.
@juliushaertl @georgehrke @skjnldsv what should this look like?
IMO this should, for simple use cases, offer to display a colored single-letter avatar like the image placeholder jQuery plugin in server, but as a Vue component. Additionally, the component should allow custom URLs to images (on external servers).
The text was updated successfully, but these errors were encountered: