Skip to content

Commit

Permalink
Merge pull request #5167 from nextcloud-libraries/fix/noid/styleguide…
Browse files Browse the repository at this point in the history
…-teleport

[next] fix(docs): bring back NcAppSidebar in docs
  • Loading branch information
raimund-schluessler authored Jan 30, 2024
2 parents 0ab9b58 + 0710c9a commit 73eb961
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions src/components/NcContent/NcContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ It also will set the skip content buttons needed for accessibility.

```vue
<template>
<div id="skip-actions" />
<NcContent app-name="forms">
<NcAppNavigation>
<template #list>
Expand All @@ -49,9 +50,9 @@ It also will set the skip content buttons needed for accessibility.
<h2>Your main app content here</h2>
<NcButton @click="opened = !opened">Toggle sidebar</NcButton>
</NcAppContent>
<!-- Todo: Bring back once migrated
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false"></NcAppSidebar>
-->
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false">
Sidebar content
</NcAppSidebar>
</NcContent>
</template>
<script>
Expand All @@ -68,6 +69,13 @@ It also will set the skip content buttons needed for accessibility.
}
}
</script>
<style>
#content-vue {
position: relative;
width: 800px;
height: 400px;
}
</style>
```

</docs>
Expand Down Expand Up @@ -100,7 +108,6 @@ It also will set the skip content buttons needed for accessibility.
:svg="currentImage"
size="auto" />
</div>
&nbsp;<!-- TODO: Remove with vue3! This is a bug of vue-simple-portal that does not allow a single child, ref LinusBorg/vue-simple-portal#20 -->
</Teleport>
<slot />
</div>
Expand Down

0 comments on commit 73eb961

Please sign in to comment.