Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Update to @nextcloud/vue 4 #233

Closed
korelstar opened this issue Jun 20, 2021 · 5 comments
Closed

Update to @nextcloud/vue 4 #233

korelstar opened this issue Jun 20, 2021 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of

Comments

@korelstar
Copy link

Updating apps to @nextcloud/vue@4 is blocked since @nextcloud/vue-dashboard requires version 3.

@korelstar korelstar added the 1. to develop Accepted and waiting to be taken care of label Jun 20, 2021
@korelstar
Copy link
Author

korelstar commented Jun 20, 2021

By the way: is it still desired to provide these two dashboard components in a separate package? I think maintenance would be much easier after merging this project with @nextcloud/vue.

@juliushaertl @skjnldsv

@juliusknorr
Copy link
Collaborator

I personally prefer small packages for stuff that is not too widely used that is why this started off as a separate one. @skjnldsv Any concrete concerns on moving this over? I have no strong opinion on that.

Anyhow I'll prepare a new release for @nextcloud/vue@4

@mejo-
Copy link

mejo- commented Aug 3, 2021

@juliushaertl did you already find time to look into this? Otherwise I could try to allocate some time to it. I'd love to look into a dashboard widget for the Collectives app, but we would need nextcloud-vue-dashboard to be ported to @nextcloud/vue4 first.

@raimund-schluessler
Copy link
Contributor

The migration to nextcloud/vue@5 is not a big deal. The only thing that needs to be adjusted is this line:
https://github.com/nextcloud/nextcloud-vue-dashboard/blob/1e74b6b62588e0003c6a0db83843f2cacc4f0ad4/src/DashboardWidgetItem.vue#L182
that should read

			if (event.target.closest('.action-item')) {

now (because there are material design icons used now). I am happy to adjust this, but I would like to get some feedback on #407 first.

@raimund-schluessler
Copy link
Contributor

Done with the merge into the vue components in nextcloud-libraries/nextcloud-vue#2668

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1. to develop Accepted and waiting to be taken care of
Projects
None yet
Development

No branches or pull requests

4 participants