Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UploadPicker): Do not hardcode the height but use the CSS variable #1309

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(UploadPicker): Do not hardcode the height but use the CSS variable #1309

merged 1 commit into from
Aug 1, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 31, 2024

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024

Bundle Report

Changes will increase total bundle size by 2.6kB ⬆️

Bundle name Size Change
@nextcloud/upload-esm 324.38kB 1.3kB ⬆️
@nextcloud/upload-esm-cjs 327.18kB 1.3kB ⬆️

@skjnldsv skjnldsv merged commit d50a722 into main Aug 1, 2024
17 checks passed
@skjnldsv skjnldsv deleted the fix/do-not-hard-code-height branch August 1, 2024 05:29
@skjnldsv skjnldsv mentioned this pull request Aug 7, 2024
Merged
@JhayceFrancis JhayceFrancis mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files top actions bar vertically shifted cause of too big "new" button
2 participants
@susnux @skjnldsv