Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files top actions bar vertically shifted cause of too big "new" button #1275

Closed
Tracked by #46016
jancborchardt opened this issue Jul 9, 2024 · 1 comment · Fixed by #1309
Closed
Tracked by #46016

Files top actions bar vertically shifted cause of too big "new" button #1275

jancborchardt opened this issue Jul 9, 2024 · 1 comment · Fixed by #1309
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature

Comments

@jancborchardt
Copy link
Contributor

It seems the entire top action bar in Files is shifted a bit to the bottom, possibly cause of the focused share button which is too big.. Compare to the left navigation toggle position, and on the top right see that the grid/list view toggle is not correctly in the top right corner:
image
@jancborchardt jancborchardt added bug Something isn't working regression Regression of a previous working feature labels Jul 9, 2024
@jancborchardt jancborchardt mentioned this issue Jul 9, 2024
Closed
28 tasks
@susnux
Copy link
Contributor

susnux commented Jul 9, 2024

This is not nextcloud-vue issue but in reality caused by nextcloud-upload as they hardcode 44px instead of --default-clickable-area on .upload-picker

@susnux susnux transferred this issue from nextcloud-libraries/nextcloud-vue Jul 9, 2024
@susnux susnux changed the title Files top actions bar vertically shifted cause of too big share button Files top actions bar vertically shifted cause of too big "new" button Jul 9, 2024
@susnux susnux added the 1. to develop Accepted and waiting to be taken care of label Jul 9, 2024
@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Jul 10, 2024
@susnux susnux mentioned this issue Jul 31, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
2 participants
@jancborchardt @susnux