Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow registering actions for a file listing #1097

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 15, 2024

Adds new view actions

Part of nextcloud/server#5534

@Pytal Pytal added enhancement New feature or request 3. to review labels Oct 15, 2024
@Pytal Pytal requested review from susnux and skjnldsv October 15, 2024 22:41
@Pytal Pytal self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Bundle Report

Changes will increase total bundle size by 3.61kB (1.51%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/files-esm 120.71kB 1.76kB (1.48%) ⬆️
@nextcloud/files-esm-cjs 122.17kB 1.85kB (1.53%) ⬆️

skjnldsv

This comment was marked as resolved.

@Pytal Pytal force-pushed the feat/view-actions branch from 59955fd to 26fd46d Compare October 21, 2024 21:35
@Pytal Pytal requested a review from skjnldsv October 21, 2024 21:36

This comment was marked as outdated.

@Pytal Pytal enabled auto-merge October 21, 2024 22:21
lib/viewAction.ts Outdated Show resolved Hide resolved
susnux

This comment was marked as resolved.

@skjnldsv skjnldsv disabled auto-merge October 22, 2024 21:00
@Pytal Pytal force-pushed the feat/view-actions branch from 0734acc to eff761d Compare October 23, 2024 23:42
@Pytal Pytal changed the title feat: Allow registering actions for a view feat: Allow registering actions for a file listing Oct 23, 2024
@Pytal
Copy link
Contributor Author

Pytal commented Oct 23, 2024

Good points @susnux ;) I've changed the API implementation to be more flexible

@Pytal Pytal force-pushed the feat/view-actions branch from eff761d to e1b5a8e Compare October 23, 2024 23:48
@Pytal Pytal force-pushed the feat/view-actions branch from e1b5a8e to c05ea8a Compare November 5, 2024 18:57
@Pytal Pytal enabled auto-merge November 5, 2024 18:58
@Pytal Pytal merged commit f82f46c into main Nov 5, 2024
15 checks passed
@Pytal Pytal deleted the feat/view-actions branch November 5, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants