From 609385b6c188486260450e171d9e85ba72dbb971 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Wed, 21 Jun 2023 12:09:52 +0200 Subject: [PATCH 1/2] chore: update node engines to next LTS (node 20 / npm 9) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 204798e7..df462878 100644 --- a/package.json +++ b/package.json @@ -53,8 +53,8 @@ "url": "https://github.com/nextcloud/nextcloud-cypress/issues" }, "engines": { - "node": "^16.0.0", - "npm": "^7.0.0 || ^8.0.0" + "node": "^20.0.0", + "npm": "^9.0.0" }, "homepage": "https://github.com/nextcloud/nextcloud-cypress", "peerDependencies": { From 444229af73d06fe6e35d0987366a6c7759a68c26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Wed, 21 Jun 2023 12:16:40 +0200 Subject: [PATCH 2/2] fix: adjust cypress workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ --- .github/workflows/cypress.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index c306b758..d44856fc 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -23,18 +23,18 @@ jobs: name: e2e runner ${{ matrix.containers }} steps: - - name: Checkout app - uses: actions/checkout@v3 + - name: Checkout + uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 - name: Read package.json node and npm engines version - uses: skjnldsv/read-package-engines-version-actions@v2.2 + uses: skjnldsv/read-package-engines-version-actions@v2.2 # v2.1 id: versions with: - fallbackNode: '^12' - fallbackNpm: '^6' + fallbackNode: '^20' + fallbackNpm: '^9' - name: Set up node ${{ steps.versions.outputs.nodeVersion }} - uses: actions/setup-node@v3 + uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3 with: node-version: ${{ steps.versions.outputs.nodeVersion }} @@ -45,7 +45,7 @@ jobs: run: docker pull ghcr.io/nextcloud/continuous-integration-shallow-server - name: Run E2E cypress tests - uses: cypress-io/github-action@v5 + uses: cypress-io/github-action@d69252d52b9a31bad4f418f05ba2bc83687a02eb # v5.8.3 with: # cypress io record: true @@ -75,26 +75,26 @@ jobs: name: component runner ${{ matrix.containers }} steps: - - name: Checkout app - uses: actions/checkout@v3 + - name: Checkout + uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 - name: Read package.json node and npm engines version - uses: skjnldsv/read-package-engines-version-actions@v2.2 + uses: skjnldsv/read-package-engines-version-actions@v2.2 # v2.1 id: versions with: - fallbackNode: '^12' - fallbackNpm: '^6' + fallbackNode: '^20' + fallbackNpm: '^9' - name: Set up node ${{ steps.versions.outputs.nodeVersion }} - uses: actions/setup-node@v3 + uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3 with: node-version: ${{ steps.versions.outputs.nodeVersion }} - name: Set up npm ${{ steps.versions.outputs.npmVersion }} run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}" - + - name: Run Components cypress tests - uses: cypress-io/github-action@v5 + uses: cypress-io/github-action@d69252d52b9a31bad4f418f05ba2bc83687a02eb # v5.8.3 with: # to run component tests we need to use "component: true" component: true