Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials Docs page incorrectly selects Qwik code samples when navigating to NextJS (Client) #12551

Open
Mearman opened this issue Jan 26, 2025 · 3 comments
Labels
triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@Mearman
Copy link

Mearman commented Jan 26, 2025

What is the improvement or update you wish to see?

see: https://authjs.dev/getting-started/authentication/credentials?framework=next-js-client

Is there any context that might help us understand?

Image

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started/authentication/credentials?framework=next-js-client

@Mearman Mearman added the triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. label Jan 26, 2025
@Himasnhu-AT
Copy link

Here's why it is happening:

credential provider doesn't have code for nextlClient, causing it to choose qwik by default

Possible fix:

  • add nextClient code
  • or modify checks to see if nextjsclient is present or not. if not present, choose nextjs

for the later, we might need to change logic of code being rendered. right now, its based on index, and we need to modify it to choose based on name.

i can pick up issue, just need to know which is best method to resolve it

@halderjoydeep
Copy link

I also came here to raise this issue.
@Himasnhu-AT I feel second approach should be better, instead of match index, we should match with key and a fallback.

@halvaradop
Copy link
Contributor

This problem has been previously reported in issue #12451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Development

No branches or pull requests

4 participants