Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using CollectionMiddleware without exposing metrics endpoint #37

Open
pavel-khritonenko opened this issue Aug 14, 2018 · 2 comments
Open

Allow using CollectionMiddleware without exposing metrics endpoint #37

pavel-khritonenko opened this issue Aug 14, 2018 · 2 comments

Comments

@pavel-khritonenko
Copy link

pavel-khritonenko commented Aug 14, 2018 •
edited
Loading

I would like to have an option to add CollectMetricsMiddleware without being forced to have metrics are being exposed on /metrics path in AspNetCore.

Would prefer to use StandaloneService or my own on another port for security reasons.

Making CollectMetricsMiddleware / HttpMetrics classes public and simple helper for middleware registration would be enough.

Do you accept PRs?
@ahoka
Copy link
Contributor

ahoka commented Aug 14, 2018

That would be a great addition to the library.

@ahoka
Copy link
Contributor

ahoka commented Aug 29, 2018

Hi, should we expect a PR on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahoka @pavel-khritonenko