Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be polite to APIs #506

Open
Hritik14 opened this issue Jul 19, 2021 · 1 comment
Open

Be polite to APIs #506

Hritik14 opened this issue Jul 19, 2021 · 1 comment
Labels
API debt Priority: medium

Comments

@Hritik14
Copy link
Collaborator

Hritik14 commented Jul 19, 2021 •
edited
Loading

  • Respect rate limits
  • Global gentle 1s (or so) delay
  • Delays based on last visits

This could be done by implementing functions like vulnerablecode.get(url...)
@sbs2001 sbs2001 added the debt label Aug 25, 2021
@pombredanne
Copy link
Member

No function should ever make a request of its own.
We should always have a central place called from where we will be able to implement politeness and logging and retries, and so on.

@pombredanne pombredanne mentioned this issue Jan 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API debt Priority: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pombredanne @Hritik14 @sbs2001