Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomcat major versions are not a single character #483

Closed
pombredanne opened this issue Jun 14, 2021 · 1 comment
Closed

Tomcat major versions are not a single character #483

pombredanne opened this issue Jun 14, 2021 · 1 comment
Labels

Comments

@pombredanne
Copy link
Member

In https://github.com/nexB/vulnerablecode/blob/24e33966bae6124e381556e520e18f1129c352fc/vulnerabilities/importers/apache_tomcat.py#L65

i[0] is problematic as it is just grabbing one character from a version which could be None... I reckon this is to fetch the major version of tomcat, but then version 10 is out and is taking two characters making this code moot.

This should be updated to handle versions correctly without using a magic [0] instead, but proper version parsing with univers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants