Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sorting of all the OpenSSL versions ever released #61

Merged
merged 2 commits into from
May 4, 2022
Merged

Test sorting of all the OpenSSL versions ever released #61

merged 2 commits into from
May 4, 2022

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space force-pushed the test_openssl_sorting branch 4 times, most recently from 6b4d3e5 to 2dbb875 Compare April 19, 2022 11:56
@pombredanne pombredanne requested a review from TG1999 April 26, 2022 13:07
pombredanne
pombredanne requested changes Apr 26, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ... See a few nits for you consideration

src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
@keshav-space keshav-space force-pushed the test_openssl_sorting branch 2 times, most recently from 78341a2 to f3cd077 Compare May 1, 2022 19:44
@keshav-space keshav-space requested a review from pombredanne May 1, 2022 19:50
pombredanne
pombredanne requested changes May 2, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... with a minor nitpicking

src/univers/versions.py Show resolved Hide resolved
@keshav-space keshav-space force-pushed the test_openssl_sorting branch from f3cd077 to 3eda1ed Compare May 3, 2022 10:39
pombredanne
pombredanne approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@pombredanne pombredanne merged commit 6badd8d into aboutcode-org:main May 4, 2022
@keshav-space keshav-space deleted the test_openssl_sorting branch May 4, 2022 07:57
TG1999 pushed a commit to TG1999/univers that referenced this pull request May 10, 2022
@JonoYang
Merge pull request aboutcode-org#61 from nexB/update-readme
ae73ce3 
Add usage instructions to README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@TG1999 TG1999 Awaiting requested review from TG1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test the sorting of all the OpenSSL version ever released
2 participants
@keshav-space @pombredanne